Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli score fix #783

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Cli score fix #783

merged 3 commits into from
Jan 11, 2024

Conversation

mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Jan 11, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 馃敟
  • Your PR is about writing tests for already existing code :godmode:

Closes #782 and Closes #781 by

  • adding a type check and conversion on the variable input dictionary
  • copying the input pdb file to a temporary file that will be deleted immediately after use

Additionally I moved the test file for cli score (hard to maintain without CNS and prone to garbage generation) to the integration tests, thus requiring CNS to run

@mgiulini mgiulini added bug Something isn't working m|emscoring Related to emscoring module labels Jan 11, 2024
@mgiulini mgiulini self-assigned this Jan 11, 2024
@mgiulini mgiulini marked this pull request as ready for review January 11, 2024 11:16
Copy link
Contributor

@VGPReys VGPReys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the future, a new flag parameter (--keep-hydrogens) to fix the hydrogens during the topoaa step should be added enabling both non-variability in the integration tests and unchanged hydrogen positions of the structures.

@amjjbonvin
Copy link
Member

in the future, a new flag parameter (--keep-hydrogens) to fix the hydrogens during the topoaa step should be added enabling both non-variability in the integration tests and unchanged hydrogen positions of the structures.

Probably not needed as I found the cause of the "energetic instability" in the rebuild process... Will create a separate issue for this

@mgiulini mgiulini merged commit 16f3fda into main Jan 11, 2024
4 checks passed
@mgiulini mgiulini deleted the cli_score_fix branch January 11, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working m|emscoring Related to emscoring module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

input file modified by cli score type checking on cli_score
3 participants