Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct behaviour and improves selaltloc #136

Merged
merged 2 commits into from
Jun 18, 2022
Merged

Correct behaviour and improves selaltloc #136

merged 2 commits into from
Jun 18, 2022

Conversation

joaomcteixeira
Copy link
Member

In some cases, the residue previous to the altloc group was discarded. This PR corrects that behaviour.

@joaomcteixeira
Add new tests
e21d876 
* add tests for the new scenario
* add vu7.pdb for tests that went missing on previous version
@joaomcteixeira
correct implementation and add tests
6b4b720
@joaomcteixeira joaomcteixeira self-assigned this Jun 17, 2022
@joaomcteixeira joaomcteixeira mentioned this pull request Jun 17, 2022
Merged
JoaoRodrigues
JoaoRodrigues approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@JoaoRodrigues JoaoRodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given so much testing, I'm assuming it works fine :)

@JoaoRodrigues JoaoRodrigues merged commit 575db16 into haddocking:master Jun 18, 2022
JoaoRodrigues pushed a commit to joaomcteixeira/pdb-tools that referenced this pull request Jun 18, 2022
@joaomcteixeira @JoaoRodrigues
Correct behaviour and improves selaltloc (haddocking#136)
db2c86e 
* Add new tests

* add tests for the new scenario
* add vu7.pdb for tests that went missing on previous version

* correct implementation and add tests
@joaomcteixeira joaomcteixeira deleted the selaltloc branch June 19, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoaoRodrigues JoaoRodrigues JoaoRodrigues approved these changes

@amjjbonvin amjjbonvin Awaiting requested review from amjjbonvin

Assignees

@joaomcteixeira joaomcteixeira

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joaomcteixeira @JoaoRodrigues