Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pdb_selmodel for model selection in ensemble PDB files. #144

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Implement pdb_selmodel for model selection in ensemble PDB files. #144

merged 3 commits into from
Jun 23, 2022

Conversation

JoaoRodrigues
Copy link
Member

@JoaoRodrigues JoaoRodrigues commented Jun 22, 2022 •
edited
Loading

Closes #122.

Adds pdb_selmodel based off pdb_selchain and tests.

joaomcteixeira
joaomcteixeira approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@joaomcteixeira joaomcteixeira left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic.

Small suggestion. Add a short sentence before the usage saying: "PDBs without models are returned unchanged regardless of the input options."

Remember this has to go with [FEATURE]

@JoaoRodrigues JoaoRodrigues merged commit 2a00556 into haddocking:master Jun 23, 2022
@JoaoRodrigues JoaoRodrigues deleted the pdb_selmodel branch June 23, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaomcteixeira joaomcteixeira joaomcteixeira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pdb_selmodel
2 participants
@JoaoRodrigues @joaomcteixeira