pdb_reres was ignoring MODEL lines #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `pdb_reres` was ignoring `MODEL` lines, and these were omitted in the output * `MODEL` lines are now piped to the output.
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 81.69% 81.76% +0.06%
==========================================
Files 44 44
Lines 3530 3532 +2
Branches 741 741
==========================================
+ Hits 2884 2888 +4
+ Misses 456 455 -1
+ Partials 190 189 -1
Continue to review full report at Codecov.
|
|
I am preparing the tests |
* tests against MODELS of a single residue * tests against MODELS of multiple residues * created a new tests/data file.
|
With the tests, the CI passes properly, give it a look and let me know if you find it appropriate for merge or not. |
JoaoRodrigues
approved these changes
Aug 2, 2020
|
Thanks @joaomcteixeira ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdb_rereswas ignoringMODELlines, and these were omitted in the outputMODELlines are now piped to the output.