Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignores CONECT lines in pdb_tidy #74

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

joaomcteixeira
Copy link
Member

After the discussion in #72, pdb_tidy now ignores CONECT lines, removing them from the output.

Closes #72

After the discussin in haddocking#72, `pdb_tidy` now ignores `CONECT` lines,
    removing them from the output.
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #74 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   81.76%   81.78%   +0.02%     
==========================================
  Files          44       44              
  Lines        3532     3520      -12     
  Branches      741      737       -4     
==========================================
- Hits         2888     2879       -9     
+ Misses        455      453       -2     
+ Partials      189      188       -1     
Impacted Files Coverage Δ
pdbtools/pdb_tidy.py 78.64% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36208c9...f47d2e4. Read the comment docs.

pdbtools/pdb_tidy.py Outdated Show resolved Hide resolved
tests/test_pdb_tidy.py Show resolved Hide resolved
@JoaoRodrigues
Copy link
Member

Approved! Thanks!

@joaomcteixeira joaomcteixeira merged commit bb103d7 into haddocking:master Aug 11, 2020
@joaomcteixeira joaomcteixeira deleted the CONECT branch August 11, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling CONECT entries
2 participants