Added -strict option to pdb_tidy to avoid adding intra-chain TERs #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
- Coverage 82.09% 81.85% -0.24%
==========================================
Files 45 45
Lines 3574 3594 +20
Branches 748 753 +5
==========================================
+ Hits 2934 2942 +8
- Misses 451 461 +10
- Partials 189 191 +2
Continue to review full report at Codecov.
|
joaomcteixeira
previously requested changes
Aug 25, 2020
There was a problem hiding this comment.
I don't see the relation between this implementation and #70. However, the idea is a good one on its own.
Requeted minor changes, and is good to go; given tests pass 😉
Cheers,
|
Er... Made the changes you requested. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses the points raised in #70 by adding a
-strictoption topdb_tidythat prevents the tool from adding TER records on chain breaks. The default behavior is to add TERs on chain breaks, is this OK @amjjbonvin ?