-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to Python3.9+ and freesasa to 2.2.1 #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks the macos installation:
https://github.com/haddocking/prodigy/actions/runs/7035702037/job/19178036334?pr=29
It actually made it work on my mac… Without upgrading to 2.2.1 the installation failed (same issue Vlad had with freesasa and haddock3)
Ot is it a poetry issue?
|
The test is showing it, see my message above. It also has been working without issues, what is the motivation for this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 56.10% 56.10%
=======================================
Files 8 8
Lines 442 442
=======================================
Hits 248 248
Misses 194 194 ☔ View full report in Codecov by Sentry. |
The motivation is that with freesasa2.1.1 the installation fails. Again an issue reported by Vlad when installing haddock3. Has to do with the latest compiler versions. freesasa2.2.1 solves the issue and the installation works fine. On my mac poetry works fine and the unit tests are passing. The failure in the actions above are related to poetry it seems. And I also removed the poetry.lock file from the repo as it should be created when running |
I'm not aware of this, could you please link this discussion/issue here? I don't understand how a failure in HADDOCK3 installation is related to PRODIGY. |
… into update-freesasa
This was a discussion in our slack channel - we don't have an issue about it as far as I can see. In the haddock3 requirements we have freesasa==2.2.0.post3 as requirement. Should probably update to 2.2.1 This was only happening on a very recent Ubuntu version. And on my mac which is freshly installed and thus has a recent compiler version. |
With the old 2.1.0 freesasa version installation fails because of a compiler issue (a problem noticed also for haddock3 by Vlad). Updating to 2.2.1 makes it work.