Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to Python3.9+ and freesasa to 2.2.1 #29

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

amjjbonvin
Copy link
Member

With the old 2.1.0 freesasa version installation fails because of a compiler issue (a problem noticed also for haddock3 by Vlad). Updating to 2.2.1 makes it work.

@amjjbonvin amjjbonvin self-assigned this Nov 29, 2023
Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amjjbonvin
Copy link
Member Author

amjjbonvin commented Nov 30, 2023 via email

@rvhonorato
Copy link
Member

rvhonorato commented Nov 30, 2023

The test is showing it, see my message above.

It also has been working without issues, what is the motivation for this?

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bcdc54b) 56.10% compared to head (45a2166) 56.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   56.10%   56.10%           
=======================================
  Files           8        8           
  Lines         442      442           
=======================================
  Hits          248      248           
  Misses        194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amjjbonvin
Copy link
Member Author

amjjbonvin commented Nov 30, 2023

The motivation is that with freesasa2.1.1 the installation fails. Again an issue reported by Vlad when installing haddock3. Has to do with the latest compiler versions. freesasa2.2.1 solves the issue and the installation works fine.

On my mac poetry works fine and the unit tests are passing. The failure in the actions above are related to poetry it seems.
Seems a python version issue. Updating the requirements to use python >=3.9 makes the test pass!

And I also removed the poetry.lock file from the repo as it should be created when running poetry install

@rvhonorato rvhonorato changed the title Updated the freesasa version to 2.2.1 to avoid compiler issues Update dependencies to Python3.9+ and freesasa to 2.2.1 Nov 30, 2023
@rvhonorato
Copy link
Member

rvhonorato commented Nov 30, 2023

The motivation is that with freesasa2.1.1 the installation fails. Again an issue reported by Vlad when installing haddock3. Has to do with the latest compiler versions. freesasa2.2.1 solves the issue and the installation works fine.

I'm not aware of this, could you please link this discussion/issue here? I don't understand how a failure in HADDOCK3 installation is related to PRODIGY.

@amjjbonvin
Copy link
Member Author

This was a discussion in our slack channel - we don't have an issue about it as far as I can see. In the haddock3 requirements we have freesasa==2.2.0.post3 as requirement. Should probably update to 2.2.1

This was only happening on a very recent Ubuntu version. And on my mac which is freshly installed and thus has a recent compiler version.

@rvhonorato rvhonorato merged commit c1716e8 into main Nov 30, 2023
11 checks passed
@rvhonorato rvhonorato deleted the update-freesasa branch November 30, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants