Skip to content
This repository has been archived by the owner on Nov 23, 2018. It is now read-only.

Fixed the super() call #2

Closed
wants to merge 3 commits into from
Closed

Conversation

cicobalico
Copy link

This works for Python 2.7.9 on ubuntu 15.04
do you think this is acceptable?

@hadim
Copy link
Owner

hadim commented Aug 31, 2016

Hello @cicobalico and thank you for this PR.

Nowdays Python 3 is becoming more and more mainstream and I really don't want to have to use Python 2 features when I can make the code prettier and easier to read with Python 3 only features. I would prefer to not bother with Python 2 compatibility.

Do you think you can switch to Python 3 ?

If your distribution does not have Python 3 I would strongly suggest you to use Anaconda as your main Python distribution for your development : http://conda.pydata.org/docs/install/quick.html

@hadim
Copy link
Owner

hadim commented Aug 31, 2016

In Ubuntu 15.04 Python 3 is already installed so you just have to do execute your code with python3. But as I said I would suggest you to use Anaconda.

@hadim
Copy link
Owner

hadim commented Sep 1, 2016

Did you find a way to use Python 3 ?

@cicobalico
Copy link
Author

cicobalico commented Sep 1, 2016

Thank you for your help @hadim ,
I did try to run my script under python3 but there are some incompatible libraries and most of my code is old and outdated.
Next time I start from scratch I'll make sure to script in python3
For the time being I wanted to try to adapt your scripts for python 2 in a fork if that is acceptable, but this is my first github contribution experience and I have to say I'm a little lost with all the forking branching merging and PRing.
Any tip/rule I might be missing would be greatly appreciated!

@hadim
Copy link
Owner

hadim commented Sep 2, 2016

Well the correction you did in your fork should make keras-toolbox works with Python 2. So unless you have a Python 3 compatible code I would suggest you to use your fork.

Ask me if you have any more questions.

@hadim hadim closed this Sep 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants