check_cran(): use check_r_cmd() instead of R() #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
wch
added a commit
that referenced
this pull request
Dec 11, 2012
check_cran(): use check_r_cmd() instead of R()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this series of commits its to make it possible for
check_cranto use the internalcheck_r_cmdfunction, so that it's easier to use the same framework for setting environment variables related to R CMD check. This will be useful for simulating CRAN more closely.Notes:
check_r_cmdinstead ofcheckis thatcheckuses stuff related to the package object, whereascheck_r_cmddoes not. (Actually,check_r_cmddid get the name from the package object, but that wasn't necessary so I took it out.)check_r_cmdnow gets the name of the package from the name of the input tar file.check_r_cmdnow can take an argument for the destination directory.