Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_aes and required_aes should both be functions #1178

Closed
wch opened this issue Jul 20, 2015 · 2 comments
Closed

default_aes and required_aes should both be functions #1178

wch opened this issue Jul 20, 2015 · 2 comments

Comments

@wch
Copy link
Member

wch commented Jul 20, 2015

Presently, one of these is a constant string, and the other is a function. They should both be functions, for consistency.
@hadley
Copy link
Member

hadley commented Jul 21, 2015

Both can be turned into constants.

@hadley
Copy link
Member

hadley commented Jul 21, 2015

And guide_geom can be also be turned into a constant.

@wch wch closed this as completed in a57c92f Jul 21, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hadley @wch