Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 4 - Wrong URL to download data #617

Open
emsing opened this issue Jun 12, 2023 · 4 comments
Open

Chapter 4 - Wrong URL to download data #617

emsing opened this issue Jun 12, 2023 · 4 comments

Comments

@emsing
Copy link

emsing commented Jun 12, 2023

In the online version of the book, I was unable to download the NEISS data using the code from the book. The URL: https://github.com/hadley/mastering-shiny/raw/master/neiss/

gave a 404 message.

I found this URL to work
https://github.com/hadley/mastering-shiny/raw/main/neiss/

@robertberryuk
Copy link

Awesome, thanks - this was driving me mad

@rmflight
Copy link

rmflight commented Dec 3, 2023

What's weird, is that the source of the page shows the correct URL (using the main branch), but the rendered shows the incorrect.

I think the book just (I know that's not necessarily that simple) needs to be re-rendered and pushed up.

@RyanGerardHoward
Copy link

Thanks emsing. That URL was helpful.

@ayoraind
Copy link

In my case (as stated in issue #609), I had to use

https://raw.githubusercontent.com/hadley/mastering-shiny/main/neiss/

So, the function then looks like this

download <- function(name) {
  # url <- "https://github.com/hadley/mastering-shiny/raw/master/neiss/"
  url <- "https://raw.githubusercontent.com/hadley/mastering-shiny/main/neiss/"
  download.file(paste0(url, name), paste0("neiss/", name), quiet = TRUE)
}

I commented out the url stated in the online version of the book for emphasis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants