rename() produces error/warning/message/silent of duplicate names would result -addresses #127
#186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix windows segfault?
Changed test from `is.vector` to `is.atomic`, in order to fix Issue 130.
Added tests for passing factors and Dates to count.
This acheives linear performance for rbind.fill on arrays, chars, lists. Factors and POSIXt values will still be quadratic.
Conflicts: NEWS inst/tests/test-rbind.r
The test suite sometimes gives errors like "rbind.fill performance linear with factors - p[2]/p[1] < threshold isn't true". But I think it's unrelated to changes I've made to `plyr::rename()`.
|
Could you please rebase/merge off master to avoid all the extra commits? |
|
I'm closing this pull request in favor of the more concise #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite sometimes gives errors like
But I'm pretty sure it's unrelated to changes I've made to
plyr::rename().