str_view(), repetition at most n times yields error #807, and small typos in "Iteration chapter" #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderlindenma
changed the title
|
How about just changing it to |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix related to this issue: #807
A more comprehensive fix should perhaps discuss why "
{,m}: at most m" does not work (or warn the reader that it does not)?Or perhaps the error message when using
{,m}is clear enough and the inclusion of{,m}in the book is intentional (in the sense that it discusses a valid regex, albeit one that does not work withstingr, and is judiciously not included in the examples ofstingrapplications)?(The second commit corrects some small typos in the "Iteration" chapter)