Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should not stop the CI / exit = 0 #17

Closed
pascalandy opened this issue Dec 30, 2020 · 1 comment · Fixed by #32
Closed

It should not stop the CI / exit = 0 #17

pascalandy opened this issue Dec 30, 2020 · 1 comment · Fixed by #32
Assignees

Comments

@pascalandy
Copy link

I use this action to keep trace of best practices. It should not stop the CI . Is is possible ?

Thanks!

@jgstew
Copy link

jgstew commented Mar 21, 2021

Ideally this would be configurable. In my use cases I have separate github actions and want the ones that fail to have non-zero exit.

That said, there are use cases where you want the tool to run on an existing file but you don't want it to be considered a failure because you are in an ongoing effort to move to best practices.

If you have a few known issues, then you could just have them ignored in a config file and then when you want to validate, do a custom run without the config file to double check divergence from best practices.

m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue May 8, 2021
- bump Hadolint version to 2.4.0
- change to debian based image
- add common config options
- expand integration tests for new options

fixes: hadolint#5
fixes: hadolint#8
fixes: hadolint#17
fixes: hadolint#18
fixes: hadolint#31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants