Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure-threshold is not supported anymore #36

Closed
marghidanu opened this issue Jul 15, 2021 · 0 comments · Fixed by #43
Closed

failure-threshold is not supported anymore #36

marghidanu opened this issue Jul 15, 2021 · 0 comments · Fixed by #43

Comments

@marghidanu
Copy link

marghidanu commented Jul 15, 2021 •
edited

While trying to set the failure-threshold to error I get the following output:

Unexpected input(s) 'failure-threshold', valid inputs are ['entryPoint', 'args', 'dockerfile']

This makes hadolint default to info which causes the pipeline to fail on everything. This is happening with version 1.4.0
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 18, 2021
@m-ildefons
features: config options, saving to file, SARIF
3a3e5b8 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 18, 2021
@m-ildefons
features: config options, saving to file, SARIF
59f4c0d 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 18, 2021
@m-ildefons
features: config options, saving to file, SARIF
2c6922f 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
@m-ildefons m-ildefons mentioned this issue Nov 18, 2021
Merged
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 19, 2021
@m-ildefons
features: config options, saving to file, SARIF
4b792c9 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 20, 2021
@m-ildefons
features: config options, saving to file, SARIF
b3cc1a3 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 20, 2021
@m-ildefons
features: config options, saving to file, SARIF
00d6164 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
m-ildefons added a commit to m-ildefons/hadolint-action that referenced this issue Nov 20, 2021
@m-ildefons
features: config options, saving to file, SARIF
98fb3f8 
- Upgrade to Hadolint 2.8.0, enabling the SARIF formatter
- Expand config options to reflect more of those regularly available
  with Hadolint including `no-fail` and `failure-threshold` options
- Enable the creation of report files

Breaking change: The list of ignored rules is now comma separated and
not space separated.

fixes: hadolint#23
fixes: hadolint#36
fixes: hadolint#42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

features: config options, saving to file, SARIF m-ildefons/hadolint-action
1 participant
@marghidanu