Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DL4000 Maintainer not recognised correctly #17

Closed
afternoon opened this issue Jan 18, 2016 · 3 comments
Closed

DL4000 Maintainer not recognised correctly #17

afternoon opened this issue Jan 18, 2016 · 3 comments
Assignees
Labels

Comments

@afternoon
Copy link

A DL4000 (specify maintainer) error is displayed for the following Dockerfile, despite a maintainer field being present. Changing email doesn't make any difference.

FROM python
MAINTAINER Ben Godfrey <foo@example.com>

In fact the example from the DL4000 wiki page also fails:

FROM busybox
MAINTAINER Lukas Martinelli <me@lukasmartinelli.ch>
@afternoon
Copy link
Author

Looking through the code, I can't see any obvious reason why this wouldn't work.

@lukasmartinelli
Copy link
Collaborator

It was a bad one. Parser fail. Because of the @ in the email
the parser tried to match a digested docker base image FROM <image>@<digest>.
And therefore there was no Maintainer but a DigestedImage in the AST.

Thanks for noticing.

@afternoon
Copy link
Author

Of course! Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants