bugfix: display version string correctly #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Construct the version string correctly when not compiling in a git directory. This bug was caused by a typo and a misunderstanding of the code when the version string logic was moved from app/Main.hs to src/Hadolint/Meta.hs in commit 3b1de5a fixes: hadolint#730
|
thanks for fixing it |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Construct the version string correctly when not compiling in a git
directory.
This bug was caused by a typo and a misunderstanding of the code when
the version string logic was moved from app/Main.hs to
src/Hadolint/Meta.hs in commit 3b1de5a
fixes: #730
How to verify it
To verify that this actually fixes the issue, check out this commit, remove or rename the
.gitdirectory and compile Hadolint from source. The result should show the version string from the.cabalfile and the-no-gitending.When compiling from source with the
.gitdirectory, the result should show the corresponding git tag and the short git hash.