SQLAlchemy extension. #7
Conversation
luckyasser
commented
Feb 23, 2015
luckyasser
commented
- Change links representation.
- Add sqla extension module.
| class Collection(royal.Collection): | ||
| sa_model = None | ||
| sa_exceptions = None | ||
| entity_cls = None |
There was a problem hiding this comment.
This ^ doesn't look decent.. But I've tried it with zope interfaces and it doesn't look any prettier too.. Suggestions ?
There was a problem hiding this comment.
I do not get what you want to do here.
There was a problem hiding this comment.
Ok I get it: dependency injection? Should we define a clean interface of sa_model?
There was a problem hiding this comment.
Yeah, that's what I did at first.. But why only for sa_model ? what about entity_cls ?
May be we just document the expected injection ?
I used to be a fan of interfaces back in the Java and C++ days, but it doesn't sound like a python thing.. I think if we follow that notion strictly, it'll be tedious and may be unpythonic..?
| self.name) | ||
|
|
||
| def on_traversing(self, key): | ||
| self.load_entity() |
|
|
||
| class Collection(royal.Collection): | ||
|
|
||
| sa_model = None |
|
|
||
| @staticmethod | ||
| def flush(): | ||
| Session.flush() |
|
Please update version number in setup.cfg file. |
