Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Helix is to change queries precedence order #216

Open
postsolar opened this issue Jan 29, 2024 · 2 comments
Open

Helix is to change queries precedence order #216

postsolar opened this issue Jan 29, 2024 · 2 comments
Labels
prio:medium Something requiring attention

Comments

@postsolar
Copy link
Contributor

See helix-editor/helix#9436

This doesn't affect existing KTS users because queries' versions are pinned, but any updates will require to adapt the ordering as well, and reverse the existing in-house queries.

@the-mikedavis
Copy link

Also see tree-sitter/tree-sitter#2396

If you're using the tree-sitter-highlight crate then you can pass in a new parameter to switch the precedence once the new changes are released (tree-sitter/tree-sitter#2412). I assume that it will become the default before the next release.

@hadronized
Copy link
Owner

Thanks for reaching about it!

If you're using the tree-sitter-highlight crate

Unfortunately, yes, I’m still using it, because reimplementing it with tree-sitter only is a ton of work. Honestly, I think the work done in Helix could be upstreamed to a crate or something else so that it can be used by others? The problem with tree-sitter-highlight is that it doesn’t share the Tree, so semantic objects require another pass of parsing (and I don’t like that). So far, semantic text-objects are not supported by KTS because of that. :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prio:medium Something requiring attention
Projects
None yet
Development

No branches or pull requests

3 participants