feat: add an --apply-all-captures argument to highlight & test
#2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaanq
commented
Jul 20, 2023
amaanq
force-pushed
the
apply-all-captures
branch
from
5e53153
to
aafd94c
Compare
amaanq
requested review from
ahlinc and
maxbrunsfeld
and removed request for
ahlinc
ahlinc
reviewed
Jul 20, 2023
amaanq
force-pushed
the
apply-all-captures
branch
from
bb82d49
to
ae5ef77
Compare
amaanq
force-pushed
the
apply-all-captures
branch
from
ae5ef77
to
82426fd
Compare
|
A couple notes: Queries by default are still used from either the one specified in package.json or tree-sitter-LANG/queries, this makes it hard for downstream to specify their own queries - I can add another flag for this if that'd be ok I made the convention style for custom files simple, newline separated strings, but comments are allowed starting with |
amaanq
force-pushed
the
apply-all-captures
branch
from
82426fd
to
acab53c
Compare
|
@patrickt @dcreager (or matter of fact anyone on @tree-sitter/semantic-code), it'd be nice to get some thoughts on the linked issue, Max's words, and this PR. Currently this PR is not a breaking change but a followup one to make last-wins precedence the default would be, as Max and I (and others) agree that it's definitely much better to work with than short-circuiting. |
amaanq
force-pushed
the
apply-all-captures
branch
3 times, most recently
from
a97bfb5
to
7ee9314
Compare
maxbrunsfeld
approved these changes
Aug 18, 2023
amaanq
force-pushed
the
apply-all-captures
branch
from
7ee9314
to
9cc508e
Compare
amaanq
force-pushed
the
apply-all-captures
branch
from
9cc508e
to
ce4a9ef
Compare
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2396