Skip to content
This repository has been archived by the owner on Apr 29, 2024. It is now read-only.

Refactor the code #249

Open
hadronized opened this issue Feb 27, 2024 · 1 comment
Open

Refactor the code #249

hadronized opened this issue Feb 27, 2024 · 1 comment
Labels
prio:high High priority (user-visible impact, etc.)

Comments

@hadronized
Copy link
Owner

hadronized commented Feb 27, 2024

With the introduction of text-objects and a redesign of buffer streaming coming up, it’s time to refactor a bit. We could start by extracting every type in its own module, and classify modules in different parts:

  • server; everything that revolves around the concept of client/server (UNIX handler, FIFO management, etc.)
  • protocol; everything that revolves around the concept of encoding messages (requests, responses, basically)
  • tree_sitter; everything that revolves around actually doing something with buffers and tree-sitter. Buffers are parsed into tree-sitter trees, and we can highlight and run text-objects.
  • kakoune; everything that relates to Kakoune, like the kak -p thing; sessions; locations / pos / selections, etc.; ideally, we could almost even think of this module as a crate we could externalize and share with e.g. kakoune-lsp (@krobelus).
  • rc, the resources that we will inject at startup of a session; that is going to be useful later when we let users pick their features from this module.
@hadronized hadronized added this to the kak-tree-sitter v0.6 milestone Feb 27, 2024
@hadronized
Copy link
Owner Author

Same thing with ktsctl; it’s a mess now.

hadronized added a commit that referenced this issue Mar 29, 2024
hadronized added a commit that referenced this issue Mar 31, 2024
hadronized added a commit that referenced this issue Apr 2, 2024
hadronized added a commit that referenced this issue Apr 3, 2024
hadronized added a commit that referenced this issue Apr 5, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
hadronized added a commit that referenced this issue Apr 14, 2024
@hadronized hadronized added the prio:low Low priority label Apr 23, 2024
hadronized added a commit that referenced this issue Apr 24, 2024
Relates #223, but not sure it fixes it. I want to redesign the whole buffer streaming (#249) so this is a temporary fix
until we got something more robust — along with lazy commands (#240).

Thanks [@robem](#223 (comment)) for suggesting the
fix.
@hadronized hadronized added prio:high High priority (user-visible impact, etc.) and removed prio:low Low priority labels Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prio:high High priority (user-visible impact, etc.)
Projects
None yet
Development

No branches or pull requests

1 participant