This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Introduce user-only configuration. #238 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadronized
force-pushed
the
238-merge-configs
branch
from
b08e861
to
360d316
Compare
That commit allows to decouple what the user can customize (which is mostly optional), and we want really want to be there (which is requiring almost everything to be provided). That requires being able to merge user configurations with regular configurations, and to create a regular configuration from a user configuration (for instance, when adding a new language config via the user configuration only), which can fail if some options are not provided.
hadronized
force-pushed
the
238-merge-configs
branch
from
c960d58
to
be149c5
Compare
The extra logging (debug) allows to check exactly with which configuration we are running. A full dump of the configuration is sunk to the logger implementation via a trace! call.
hadronized
force-pushed
the
238-merge-configs
branch
from
be149c5
to
34086b7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That commit allows to decouple what the user can customize (which is mostly optional), and what we really want to be there (which is requiring almost everything to be provided). That requires being able to merge user configurations with regular configurations, and to create a regular configuration from a user configuration (for instance, when adding a new language config via the user configuration only), which can fail if some options are not provided.