Fix buffer target corruption in WebGL2 backend. #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadronized
force-pushed
the
fix/483-webgl-index-buffer-corruption
branch
3 times, most recently
from
352a90a
to
0bb49ae
Compare
hadronized
force-pushed
the
fix/483-webgl-index-buffer-corruption
branch
3 times, most recently
from
f40d179
to
e3c1628
Compare
In the OpenGL 3.3 backend, there is an optimization that allows a buffer object to be created and bound to a given target (for instance `ARRAY_BUFFER`) and allows to rebind the buffer later to another target (for instance `ELEMENT_ARRAY_BUFFER`). That optimization is handy because it allows to dissociate data storage from data representation, allowing to send a bunch of bytes and then using the target as source of representation. Well, turns out that optimization doesn’t work in WebGL2, so this commit implements a way to keep track of what a buffer was created as and then re-use that information every time we need to bind the buffer. That should fix #483 (and probably other bugs no one has encountered yet). Some integration tests are needed to ensure the fix does what it should.
This relates to #483 for testing corruption of `indices_mut()`. The example showcases the bug when used on the `web` executor (no issue with the `desktop` one). This bug is fixed in the next commit.
The bug was due to still using `bind_array_buffer` when streaming buffer updates to the GPU. Relates to #483.
hadronized
force-pushed
the
fix/483-webgl-index-buffer-corruption
branch
from
e3c1628
to
ba6d169
Compare
|
Merging this as it’s already a fix, and I will continue fixing the buffer problems by redesigning them a bit. It shouldn’t be a big breaking change but it might still be one so I want to do that in another PR. |
hadronized
force-pushed
the
fix/483-webgl-index-buffer-corruption
branch
from
a33140b
to
e491d41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the OpenGL 3.3 backend, there is an optimization that allows a
buffer object to be created and bound to a given target (for instance
ARRAY_BUFFER) and allows to rebind the buffer later to anothertarget (for instance
ELEMENT_ARRAY_BUFFER). That optimization is handybecause it allows to dissociate data storage from data representation,
allowing to send a bunch of bytes and then using the target as source of
representation.
Well, turns out that optimization doesn’t work in WebGL2, so this commit
implements a way to keep track of what a buffer was created as and then
re-use that information every time we need to bind the buffer. That
should fix #483 (and probably other bugs no one has encountered yet).
Some integration tests are needed to ensure the fix does what it should.