Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: grunt karma #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: grunt karma #4

wants to merge 1 commit into from

Conversation

rafinskipg
Copy link

Hi, hadronjs

I know that this Pull Request may be discarded, but here are my suggestions on what I saw.

HadronJS needs Bower, (angular mock was outdated and I lost nearly 2 hours trying to find the problem , and was the version)

I'll suggest putting more tasks centralized in the gruntfile, i can do it. I started with karma because i saw the admin angular app needs a refactor, i can help with that, too.

So those are my suggestion : Bower && more grunt

This pull request includes the first integration with grunt-karma, and the first setup for testing a controller, which we could continue.

Good night, and, good job, hadron rocks, I liked it very much!

@rafinskipg
Copy link
Author

Maybe It doesn't need bower, if you include angular-mock.js / angular-resource, etc etc in the particles-angular

@mariocasciaro
Copy link
Contributor

Thanks, the idea is great. But these changes should be applied to the new Hadron 0.3 codebase. In particular grunt will be replaced by gulp, so most of these changes are not valid anymore with the new code.
Also please consider that Hadron has its own asset manager, based on Particles, so bower is not necessary (at least for now).

@rafinskipg
Copy link
Author

Yep, I'll wait till 0.3 is released for contributing.

Anyway, what way do you suggest for using angular-mock ? Another particle or including it in the existing angular particle?

@mariocasciaro
Copy link
Contributor

I think for now we can just include it in the main hadron package, in a location where we can keep it separated from the production assets. We can then think later to include it in the angular particle or a separate particle. Let's start small and simple, we refactor as soon as we have a better understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants