Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get as_plotly working #16

Open
wants to merge 2 commits into
base: plotly
Choose a base branch
from
Open

Get as_plotly working #16

wants to merge 2 commits into from
+26 −2

Conversation

cpsievert
Copy link

No description provided.

@hafen
Copy link
Owner

hafen commented Dec 20, 2016

Thanks @cpsievert! Actually, after you explained that I wasn't evaluating evals, I made that fix in trelliscopejs-lib (trelliscope/trelliscopejs-lib@2de2fe9). This will make TrelliscopeJS more robust to other htmlwidgets as well. So now things work without this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpsievert @hafen