Add support for HmIPW-DRS4 Switch Actuator #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vielen Dank! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I basically copied what I found about the DRS8 actuator, adopted it to match the DRS4 and applied it.
I manually tested it and without these changes the
--list-devicesjust returned<homematicip.device.BaseDevice object at 0x101a25780>. After applying my changes the same command returned a proper description of the device as DRS4.I also tested the
--turn-onand--turn-offcommands successfully with different channels.I'd appreciate if someone else can review my changes and support this PR by adding proper tests.
Closes #436