Disable undo in autogenerated state machines #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems consistent with what I observed in a non-backported change from CGE Ref #24 |
Happyrobot33
suggested changes
Dec 9, 2022
| @@ -112,7 +113,11 @@ public AacFlIntParameterGroup IntParameters(params AacFlIntParameter[] parameter | |||
|
|
|||
| internal class AacStateMachine | |||
| { | |||
| private static readonly PropertyInfo PropPushUndo = typeof(AnimatorState).GetProperty("pushUndo", | |||
There was a problem hiding this comment.
AnimatorState needs to be changed to AnimatorStateMachine, or else there will be an error due to types not matching
|
This also needs to add in the undo change for AacFlCondition as those generate undo states aswell |
suzuryg
added a commit
to suzuryg/av3-animator-as-code
that referenced
this pull request
Feb 18, 2023
Happyrobot33
added a commit
to Happyrobot33/av3-animator-as-code
that referenced
this pull request
May 16, 2023
|
A similar fix was added to AAC V1: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unity's undo processing gets extremely slow when dealing with large numbers of newly created objects. I suspect there may be some O(n^2) scaling going on there. Regardless, this change disables undo for the AAC-handled state machines to avoid this issue.