Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for include_, refactoring #17

Merged
merged 42 commits into from Apr 3, 2019
Merged

Support for include_, refactoring #17

merged 42 commits into from Apr 3, 2019

Conversation

haidaraM
Copy link
Owner

@haidaraM haidaraM commented Feb 25, 2019 •
edited

Fixes #16

This PR also :

  • adds the support for include_role, import_role, include_playbook, ...
  • Add more tests
  • Rewrite some parts of the grapher...

@coveralls
Copy link

coveralls commented Feb 25, 2019 •
edited

Coverage Status

Coverage remained the same at ?% when pulling 78f75f6 on fixIssue16NestedInclude into 8a6a666 on master.

Mohamed El Mouctar HAIDARA added 27 commits March 26, 2019 00:25
Proper handling of nested include and relative path
dbde9e2
Use TaskInclude.get_vars() instead of manually copying vars
31dfca3
Update test_example_with_roles with a test with 'import_role'
4aea1da
Add new fake_role
dd0a2d3
add new tests for include_role and import_role, new role with variables
8eefcd2
handle include_role
1aa0f67
Improve handling of include_role, use fake_role_2 for the tests
1cc8f5f
remove useless comments [ci-skip]
795c541
Check also roles_number in the svg
99f86ca
Do not remove the generated svg after the tests
54ad58e
Parametrize test related to roles with the option --include-role-tasks
e3e916f
include_role_tasks as field of the Grapher, Update fixtures fake_role_2
0619c91
Check if one of the parent of the task or block is a role
10dc356
Update tests to generated svg based on the function name
0e344e1
Update tests: run_grapher, remove os.remove
4c17684
move tests related files to tests/, FIXTURES_DIR relative to tests
0df5618
Make test test_example_import_role the last test. Need to fix that later
58175a0
Fix requirements_tests path in setup.py
ce9a61d
travis: Remove ansible 2.4, 2.5, 2.6. Update python3 to 3.6
28039f8
Pass all the options to the grapher
ee10caa
Note on my CLI and Ansible 2.9: optparse will be replaced by argparse
2c27b3e
travis: only build on master, others build should be PRs
6c1ea24
Do not include role from "import_role" to prevent duplicate
7dbaccd
Remove example prefix from tests
e03889c
New tests for import_playbook
92df88d
basedir of the loader is based on the play or playbook path
d73e942
Add test for nested import playbook and include
aa556c6
@haidaraM haidaraM mentioned this pull request Mar 25, 2019
Closed
@haidaraM haidaraM changed the title Proper handling of nested include and relative path Support for include_, refactoring Mar 29, 2019
@haidaraM haidaraM merged commit e5054b6 into master Apr 3, 2019
@haidaraM haidaraM deleted the fixIssue16NestedInclude branch April 3, 2019 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haidaraM @coveralls