Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for hiding empty plays and plays without roles #177

Merged
merged 14 commits into from Mar 25, 2024

Conversation

haidaraM
Copy link
Owner

@haidaraM haidaraM commented Mar 18, 2024

  • Add a new flag --hide-empty-plays to not show in the graph the plays that end up being empty after applying the filters.
  • Add a new flag --hide-plays-without-roles to not show in the graph the plays that end up with no roles. Only roles at the play level and include_role as tasks are considered (no import_role).

Also fixe some typos.

Related to #176

@coveralls
Copy link

coveralls commented Mar 18, 2024

Coverage Status

coverage: 95.29% (+0.1%) from 95.173%
when pulling 01fe0c6 on hide-plays
into 4979cf9 on main.

@haidaraM haidaraM changed the title feat: Add support for hiding empty plays feat: Add support for empty plays Mar 22, 2024
@haidaraM haidaraM changed the title feat: Add support for empty plays feat: Add support for hiding empty plays and plays without roles Mar 23, 2024
@haidaraM haidaraM marked this pull request as ready for review March 25, 2024 18:02
@haidaraM haidaraM merged commit 21d5410 into main Mar 25, 2024
7 checks passed
@haidaraM haidaraM deleted the hide-plays branch March 25, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants