Skip to content

Commit

Permalink
Debugger: DebuggerInterface refactor.
Browse files Browse the repository at this point in the history
DebuggerInterface:
- Refactor into abstract base class.
- Introduce interface configuration abstract base class.
- Move existing implementation into LocalDebuggerInterface and add
  corresponding configuration class.

Debugger:
- Adjust to instantiate LocalDebuggerInterface.

In and of itself no functional change, but paves the way for further
refactoring to make the debugger fully interface-agnostic (this isn't yet
the case for retrieving target system information such as the team listing,
and creating/attaching to teams).
  • Loading branch information
anevilyak committed Apr 3, 2016
1 parent 6bef41c commit 2e70581
Show file tree
Hide file tree
Showing 6 changed files with 1,124 additions and 1,008 deletions.
4 changes: 2 additions & 2 deletions src/apps/debugger/Debugger.cpp
Expand Up @@ -23,7 +23,7 @@
#include "debug_utils.h"

#include "CommandLineUserInterface.h"
#include "DebuggerInterface.h"
#include "LocalDebuggerInterface.h"
#include "GraphicalUserInterface.h"
#include "ImageDebugLoadingStateHandlerRoster.h"
#include "MessageCodes.h"
Expand Down Expand Up @@ -313,7 +313,7 @@ start_team_debugger(team_id teamID, SettingsManager* settingsManager,

BReference<DebuggerInterface> interfaceReference;
DebuggerInterface* debuggerInterface
= new(std::nothrow) DebuggerInterface(teamID);
= new(std::nothrow) LocalDebuggerInterface(teamID);
if (debuggerInterface == NULL)
return NULL;
interfaceReference.SetTo(debuggerInterface, true);
Expand Down
4 changes: 4 additions & 0 deletions src/apps/debugger/Jamfile
Expand Up @@ -23,6 +23,7 @@ SEARCH_SOURCE += [ FDirName $(SUBDIR) debug_info ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) debug_info loading_state_handlers ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) debug_managers ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) debugger_interface ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) debugger_interface interfaces ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) elf ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) files ] ;
SEARCH_SOURCE += [ FDirName $(SUBDIR) ids ] ;
Expand Down Expand Up @@ -137,6 +138,9 @@ local sources =
DebugEvent.cpp
DebuggerInterface.cpp

# debugger_interface/interfaces
LocalDebuggerInterface.cpp

# elf
ElfFile.cpp

Expand Down

0 comments on commit 2e70581

Please sign in to comment.