Skip to content

Commit

Permalink
Unify version output ("v" vs "Version", sentence casing.
Browse files Browse the repository at this point in the history
  • Loading branch information
Humdinger committed May 2, 2015
1 parent 51b7596 commit 3292b90
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/add-ons/translators/gif/GIFView.cpp
Expand Up @@ -56,7 +56,7 @@ GIFView::GIFView(TranslatorSettings* settings)

char version_string[100];
snprintf(version_string, sizeof(version_string),
B_TRANSLATE("v%d.%d.%d, %s"),
B_TRANSLATE("Version %d.%d.%d, %s"),
int(B_TRANSLATION_MAJOR_VERSION(GIF_TRANSLATOR_VERSION)),
int(B_TRANSLATION_MINOR_VERSION(GIF_TRANSLATOR_VERSION)),
int(B_TRANSLATION_REVISION_VERSION(GIF_TRANSLATOR_VERSION)),
Expand Down
9 changes: 6 additions & 3 deletions src/add-ons/translators/jpeg/JPEGTranslator.cpp
Expand Up @@ -671,9 +671,12 @@ TranslatorAboutView::TranslatorAboutView(const char* name)
title->SetFont(be_bold_font);
title->SetExplicitAlignment(labelAlignment);

char versionString[16];
sprintf(versionString, "v%d.%d.%d", (int)(sTranslatorVersion >> 8),
(int)((sTranslatorVersion >> 4) & 0xf), (int)(sTranslatorVersion & 0xf));
char versionString[100];
snprintf(versionString, sizeof(versionString),
B_TRANSLATE("Version %d.%d.%d"),
(int)(sTranslatorVersion >> 8),
(int)((sTranslatorVersion >> 4) & 0xf),
(int)(sTranslatorVersion & 0xf));

BStringView* version = new BStringView("Version", versionString);
version->SetExplicitAlignment(labelAlignment);
Expand Down
5 changes: 3 additions & 2 deletions src/add-ons/translators/jpeg2000/JPEG2000Translator.cpp
Expand Up @@ -713,8 +713,9 @@ TranslatorAboutView::TranslatorAboutView(const char* name)
title->SetFont(be_bold_font);
title->SetExplicitAlignment(labelAlignment);

char versionString[16];
sprintf(versionString, "v%d.%d.%d",
char versionString[100];
snprintf(versionString, sizeof(versionString),
B_TRANSLATE("Version %d.%d.%d"),
static_cast<int>(sTranslatorVersion >> 8),
static_cast<int>((sTranslatorVersion >> 4) & 0xf),
static_cast<int>(sTranslatorVersion & 0xf));
Expand Down
2 changes: 1 addition & 1 deletion src/add-ons/translators/ppm/PPMTranslator.cpp
Expand Up @@ -507,7 +507,7 @@ class PPMView :
"bits big-endian"), CSMessage(B_RGBA15_BIG)));
fMenu->AddItem(new BMenuItem(B_TRANSLATE("RGB 5:6:5 16 bits "
"big-endian"), CSMessage(B_RGB16)));
fField = new BMenuField(B_TRANSLATE("Input Color Space:"),
fField = new BMenuField(B_TRANSLATE("Input color space:"),
fMenu);
fField->SetViewColor(ViewColor());
SelectColorSpace(g_settings.out_space);
Expand Down
4 changes: 2 additions & 2 deletions src/add-ons/translators/psd/ConfigView.cpp
Expand Up @@ -45,10 +45,10 @@ ConfigView::ConfigView(TranslatorSettings *settings)
fSettings->SetGetInt32(PSD_SETTING_VERSION);

_AddItemToMenu(versionPopupMenu,
B_TRANSLATE("Photoshop Document (PSD File)"), MSG_VERSION_CHANGED,
B_TRANSLATE("Photoshop Document (PSD file)"), MSG_VERSION_CHANGED,
PSD_FILE, currentVersion);
_AddItemToMenu(versionPopupMenu,
B_TRANSLATE("Photoshop Big Document (PSB File)"), MSG_VERSION_CHANGED,
B_TRANSLATE("Photoshop Big Document (PSB file)"), MSG_VERSION_CHANGED,
PSB_FILE, currentVersion);

fVersionField = new BMenuField("version",
Expand Down
2 changes: 1 addition & 1 deletion src/add-ons/translators/tga/TGAView.cpp
Expand Up @@ -68,7 +68,7 @@ TGAView::TGAView(const char *name, uint32 flags, TranslatorSettings *settings)
fpchkIgnoreAlpha->SetValue(val);
fpchkIgnoreAlpha->SetViewColor(ViewColor());

fpchkRLE = new BCheckBox(B_TRANSLATE("Save with RLE Compression"),
fpchkRLE = new BCheckBox(B_TRANSLATE("Save with RLE compression"),
new BMessage(CHANGE_RLE));
val = (fSettings->SetGetBool(TGA_SETTING_RLE)) ? 1 : 0;
fpchkRLE->SetValue(val);
Expand Down

0 comments on commit 3292b90

Please sign in to comment.