LaunchBox: finish saving settings before closing the window (#6347)

haiku · Dec 12, 2012 · 4d6bb87 · 4d6bb87
1 parent d725054
commit 4d6bb87
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/src/apps/launchbox/App.cpp b/src/apps/launchbox/App.cpp
@@ -145,11 +145,13 @@ App::_StoreSettingsIfNeeded()
 	BMessage settings('sett');
 	for (int32 i = 0; BWindow* window = WindowAt(i); i++) {
 		if (MainWindow* padWindow = dynamic_cast<MainWindow*>(window)) {
-			BMessage* windowSettings = padWindow->Settings();
-			if (windowSettings && padWindow->Lock()) {
-				padWindow->SaveSettings(windowSettings);
+			if (padWindow->Lock()) {
+				BMessage* windowSettings = padWindow->Settings();
+				if (windowSettings) {
+					padWindow->SaveSettings(windowSettings);
+					settings.AddMessage("window", windowSettings);
+				}
 				padWindow->Unlock();
-				settings.AddMessage("window", windowSettings);
 			}
 		}
 	}

diff --git a/src/apps/launchbox/MainWindow.cpp b/src/apps/launchbox/MainWindow.cpp
@@ -90,19 +90,23 @@ MainWindow::QuitRequested()
 		if (dynamic_cast<MainWindow*>(window))
 			padWindowCount++;
 	}
-	if (padWindowCount == 1) {
-		be_app->PostMessage(B_QUIT_REQUESTED);
-		return false;
-	} else {
-		BAlert* alert = new BAlert(B_TRANSLATE("last chance"),
-			B_TRANSLATE("Really close this pad?\n"
-						"(The pad will not be remembered.)"),
-			B_TRANSLATE("Close"), B_TRANSLATE("Cancel"), NULL);
-		alert->SetShortcut(1, B_ESCAPE);
-		if (alert->Go() == 1)
-			return false;
+	bool canClose = true;
+	if (Lock()) {
+		if (padWindowCount == 1) {
+			be_app->PostMessage(B_QUIT_REQUESTED);
+			canClose = false;
+		} else {
+			BAlert* alert = new BAlert(B_TRANSLATE("last chance"),
+				B_TRANSLATE("Really close this pad?\n"
+								"(The pad will not be remembered.)"),
+				B_TRANSLATE("Close"), B_TRANSLATE("Cancel"), NULL);
+			alert->SetShortcut(1, B_ESCAPE);
+			if (alert->Go() == 1)
+				canClose = false;
+		}
+		Unlock();
 	}
-	return true;
+	return canClose;
 }