Skip to content

Commit

Permalink
Corrected check to ensure that command line options are indeed passed.
Browse files Browse the repository at this point in the history
* Currently, no command line options are being passed via u-boot
  to haiku. However, the comparison doesn't ensure that cmdline
  is not an empty string - it merely ensures cmdline is not null.

Signed-off-by: Ithamar R. Adema <ithamar@upgrade-android.com>
  • Loading branch information
dnivra authored and Ithamar committed Jun 27, 2014
1 parent cf0ba49 commit 6f742d8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/system/boot/platform/u-boot/start.cpp
Expand Up @@ -137,7 +137,8 @@ start_netbsd(struct board_info *bd, struct image_header *image,
{
const char *argv[] = { "haiku", cmdline };
int argc = 1;
if (cmdline)
// TODO: Ensure cmdline is mapped into memory by MMU before usage.
if (cmdline && *cmdline)
argc++;
gUImage = image;
return start_raw(argc, argv);
Expand Down

0 comments on commit 6f742d8

Please sign in to comment.