BString: fix Split() for multiple characters separators...

 as suggested by Janus in #14045. Thanks!
* add a unit test for BString::Split().

src/kits/support/String.cpp

@@ -525,7 +525,7 @@ BString::Split(const char* separator, bool noEmptyStrings,
 		if (endIndex == length)
 			break;
 
-		index = endIndex + 1;
+		index = endIndex + separatorLength;
 	}
 
 	return true;

src/tests/kits/support/Jamfile

@@ -74,6 +74,7 @@ UnitTestLib libsupporttest.so
 		StringCharAccessTest.cpp
 		StringSearchTest.cpp
 		StringReplaceTest.cpp
+		StringSplitTest.cpp
 
 		#BBlockCache
 		BlockCacheTest.cpp

src/tests/kits/support/bstring/StringSplitTest.cpp

@@ -0,0 +1,60 @@
+#include "StringSplitTest.h"
+#include "cppunit/TestCaller.h"
+#include <String.h>
+#include <StringList.h>
+
+StringSplitTest::StringSplitTest(std::string name) :
+		BTestCase(name)
+{
+}
+
+
+
+StringSplitTest::~StringSplitTest()
+{
+}
+
+
+void
+StringSplitTest::PerformTest(void)
+{
+	BString *str1;
+
+	NextSubTest();
+	BStringList stringList1;
+	str1 = new BString("test::string");
+	str1->Split(":", true, stringList1);
+	CPPUNIT_ASSERT(stringList1.CountStrings() == 2);
+	delete str1;
+
+	NextSubTest();
+	BStringList stringList2;
+	str1 = new BString("test::string");
+	str1->Split("::", true, stringList2);
+	CPPUNIT_ASSERT(stringList2.CountStrings() == 2);
+	delete str1;
+
+	NextSubTest();
+	BStringList stringList3;
+	str1 = new BString("test::string");
+	str1->Split("::", false, stringList3);
+	CPPUNIT_ASSERT(stringList3.CountStrings() == 2);
+	delete str1;
+
+	NextSubTest();
+	BStringList stringList4;
+	str1 = new BString("test::string");
+	str1->Split(":", false, stringList4);
+	CPPUNIT_ASSERT(stringList4.CountStrings() == 3);
+	delete str1;
+
+}
+
+
+CppUnit::Test *StringSplitTest::suite(void)
+{
+	typedef CppUnit::TestCaller<StringSplitTest>
+		StringSplitTestCaller;
+
+	return(new StringSplitTestCaller("BString::Split Test", &StringSplitTest::PerformTest));
+}

src/tests/kits/support/bstring/StringSplitTest.h

@@ -0,0 +1,22 @@
+#ifndef StringSplitTest_H
+#define StringSplitTest_H
+
+#include "TestCase.h"
+#include <String.h>
+
+
+class StringSplitTest : public BTestCase
+{
+
+private:
+
+protected:
+
+public:
+	static Test *suite(void);
+	void PerformTest(void);
+	StringSplitTest(std::string name = "");
+	virtual ~StringSplitTest();
+	};
+
+#endif

src/tests/kits/support/bstring/StringTest.cpp

@@ -16,6 +16,7 @@
 #include "StringCharAccessTest.h"
 #include "StringReplaceTest.h"
 #include "StringSearchTest.h"
+#include "StringSplitTest.h"
 
 CppUnit::Test *StringTestSuite()
 {
@@ -36,6 +37,7 @@ CppUnit::Test *StringTestSuite()
 	testSuite->addTest(StringCharAccessTest::suite());
 	testSuite->addTest(StringReplaceTest::suite());
 	testSuite->addTest(StringSearchTest::suite());
+	testSuite->addTest(StringSplitTest::suite());
 
 	return(testSuite);
 }