Fix #9294.

- Fix incorrect order of operations in ValueNodeManager. - Upon receiving a changed notification, VariableTableModel needs to make tree table aware that the previous nodes have been removed.
haiku · Dec 17, 2012 · a4df762 · a4df762
1 parent 287cda6
commit a4df762
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/apps/debugger/debug_managers/ValueNodeManager.cpp b/src/apps/debugger/debug_managers/ValueNodeManager.cpp
@@ -103,11 +103,12 @@ ValueNodeManager::ValueNodeChanged(ValueNodeChild* nodeChild,
 
 	AutoLocker<ValueNodeContainer> containerLocker(fContainer);
 
+	for (int32 i = fListeners.CountItems() - 1; i >= 0; i--)
+		fListeners.ItemAt(i)->ValueNodeChanged(nodeChild, oldNode, newNode);
+
 	if (oldNode != NULL)
 		newNode->CreateChildren();
 
-	for (int32 i = fListeners.CountItems() - 1; i >= 0; i--)
-		fListeners.ItemAt(i)->ValueNodeChanged(nodeChild, oldNode, newNode);
 }
 
 

diff --git a/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp b/src/apps/debugger/user_interface/gui/team_window/VariablesView.cpp
@@ -930,8 +930,10 @@ VariablesView::VariableTableModel::ValueNodeChanged(ValueNodeChild* nodeChild,
 	if (modelNode == NULL)
 		return;
 
-	if (oldNode != NULL)
+	if (oldNode != NULL) {
+		ValueNodeChildrenDeleted(oldNode);
 		NotifyNodeChanged(modelNode);
+	}
 }