Sizing and optimization #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulkomandy
reviewed
Aug 5, 2019
| @@ -34,7 +34,7 @@ using namespace WebCore; | |||
|
|
|||
| WebKit::WebViewBase::WebViewBase(const char*name,BRect rect,BWindow* parentWindow, | |||
| const API::PageConfiguration& pageConfig) | |||
| :BView(rect,name,B_FOLLOW_ALL_SIDES,B_WILL_DRAW), | |||
| :BView(name,B_WILL_DRAW|B_FRAME_EVENTS|B_FULL_UPDATE_ON_RESIZE), | |||
There was a problem hiding this comment.
space around |: B_WILL_DRAW | B_FRAME_EVENTS | B_FULL_UPDATE_ON_RESIZE
1) Removed that painful wait between network and webprocess connection 2) Resizing a webpage ( very slow )
1) Cleanup all the unwanted debug messages 2) More predictable rendering Next commit would focus on Indentation
also fixed spacing issue
1) Inconsistent use of spaces and tabs I had to clean up this manually as i couldnt find a good extension So i will clean even more files if i come across them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed that painful wait between network and webprocess connection
Resizing a webpage ( very slow )