Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition modes and fix for fixed elements flickering #32

Merged
merged 2 commits into from
Jul 4, 2020

Conversation

KapiX
Copy link
Member

@KapiX KapiX commented Jul 3, 2020

No description provided.

KapiX added 2 commits July 2, 2020 20:06
* It is pretty clever, but doesn't work that well with fixed elements.
* This should fix jerking of fixed elements at the top of the screen,
  for example on our forums.
* The downside is that regular content scrolling has visible artifacts
  near the top, but it's not as bad as with fixed elements.
rectAtSrc = rectAtSrc & rectAtDst;
rectAtDst.OffsetBy(xOffset, yOffset);

offscreenView->CopyBits(rectAtSrc, rectAtDst);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this means the whole webpage is always redrawn everytime one scrolls, instead of just the newly exposed part. Is that ok? Wouldn't it make scrolling on slow to draw webpages even worse?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is a trade-off. Tiled backing store could probably solve both issues, but I'm reluctant to put more work into WebKitLegacy API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point.
I had TiledBackingStore working at some point but it tends to create huge bitmaps (2048x2048) and several of them, if we would go in that direction we should at least remove the current offscreen buffer.

Well, I guess that's good enough for WebKitLegacy and start to see about moving things to WebKit2 indeed.

@pulkomandy pulkomandy merged commit 47a8eaa into haiku:rebased Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants