ImageBufferHaiku: adapt to new backends system #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How is the conversion between premultiplied alpha and B_RGB32 handled then? That's what most of the code you removed was doing (or trying to do, at least) since WebKit uses premultiplied alpha, but BBitmap doesn't handle it. Is it handled correctly by the cross-platform code? |
Introduced in aa9a420, this new system abstracts away backend-specific details from platform-specific implementations, allowing code reuse between platforms. This commit adapts Haiku's ImageBufferBackend implementation to use this new system. A new method `backendAlphaPremultiplication()` is added for dealing with BBitmap's sole support for unpremultiplied alpha. Interactions against 83cc46b remains to be seen as tests requires WebGL2. Testing with WebPositive shows more or less the same pass rate for web-platform-tests/html/canvas/element/imagebitmap against the old code path. No further tests has been done as DumpRenderTree couldn't run due to a relocation error, making automated testing difficult.
alaviss
force-pushed
the
imagebuffer-simplify
branch
from
1b6fdde
to
4c12618
Compare
It does now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in aa9a420, this new system
abstracts away backend-specific details from platform-specific
implementations, allowing code reuse between platforms.
This commit adapts Haiku's ImageBufferBackend implementation to use this
new system.
A new method
backendAlphaPremultiplication()is added for dealing withBBitmap's sole support for unpremultiplied alpha. Interactions against
83cc46b remains to be seen as tests
requires WebGL2.
Testing with WebPositive shows more or less the same pass rate for
web-platform-tests/html/canvas/element/imagebitmapagainst the old code path.No further tests has been done as
DumpRenderTreecouldn't run due toa relocation error, making automated testing difficult.