New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed missing headers from Webcore for Webkit2 #8
Changes from 9 commits
d883420
42addb5
6fdad02
09f7990
7e97e5b
1b9e6ac
31351ab
5e05c55
2cd19e0
81a496a
0d98b04
4a7a146
c80ae31
c9f0fd0
7182b92
1e1c1ad
7fc2bc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,9 +27,9 @@ | |
|
||
#include <cstdlib> | ||
|
||
#if USE(GCRYPT) | ||
/*#if USE(GCRYPT) | ||
#include <pal/crypto/gcrypt/Initialization.h> | ||
#endif | ||
#endif*/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the error i told that day the compiler couldnt identify USE maybe its because the source is happening in a seperate process? |
||
|
||
using namespace WebKit; | ||
|
||
|
@@ -45,9 +45,9 @@ int main(int argc, char** argv) | |
// WARNING: This needs to be KEPT IN SYNC with WebProcessMain.cpp. | ||
setenv("G_TLS_GNUTLS_PRIORITY", "NORMAL:%COMPAT:!VERS-SSL3.0:!ARCFOUR-128", 0); | ||
|
||
#if USE(GCRYPT) | ||
/*#if USE(GCRYPT) | ||
PAL::GCrypt::initialize(); | ||
#endif | ||
#endif*/ | ||
|
||
return NetworkProcessMainUnix(argc, argv); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
/* | ||
* Copyright (C) 2019 Haiku Inc., | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: | ||
* 1. Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* 2. Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in the | ||
* documentation and/or other materials provided with the distribution. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
* THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
#include "config.h" | ||
#include "NetworkCacheIOChannel.h" | ||
|
||
#include "NotImplemented.h" | ||
|
||
namespace WebKit { | ||
namespace NetworkCache { | ||
|
||
IOChannel::IOChannel(const String& filePath, Type type) | ||
: m_path{filePath} | ||
, m_type{type} | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
IOChannel::~IOChannel() | ||
{ | ||
} | ||
|
||
Ref<IOChannel> IOChannel::open(const String& filePath, IOChannel::Type type) | ||
{ | ||
return adoptRef(*new IOChannel(filePath, type)); | ||
} | ||
|
||
void IOChannel::read(size_t offset, size_t size, WorkQueue* queue, Function<void(Data&, int error)>&& completionHandler) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void IOChannel::write(size_t offset, const Data& data, WorkQueue* queue, Function<void(int error)>&& completionHandler) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
} // namespace NetworkCache | ||
} // namespace WebKit |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
/* | ||
* Copyright (C) 2019 Haiku, Inc. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: | ||
* 1. Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* 2. Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in the | ||
* documentation and/or other materials provided with the distribution. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
* THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
#include "config.h" | ||
#include "NetworkProcess.h" | ||
|
||
#include "NetworkProcessCreationParameters.h" | ||
#include <WebCore/NetworkStorageSession.h> | ||
#include <WebCore/NotImplemented.h> | ||
|
||
namespace WebCore | ||
{ | ||
class NetworkStorageSession; | ||
} | ||
|
||
namespace WebKit { | ||
|
||
using namespace WebCore; | ||
|
||
void NetworkProcess::platformInitializeNetworkProcess(const NetworkProcessCreationParameters& parameters) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::allowSpecificHTTPSCertificateForHost(const CertificateInfo& certificateInfo, const String& host) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
std::unique_ptr<WebCore::NetworkStorageSession> NetworkProcess::platformCreateDefaultStorageSession() const | ||
{ | ||
return std::make_unique<WebCore::NetworkStorageSession>(PAL::SessionID::defaultSessionID(), nullptr); | ||
} | ||
|
||
void NetworkProcess::platformProcessDidTransitionToForeground() | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::platformProcessDidTransitionToBackground() | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::clearCacheForAllOrigins(uint32_t cachesToClear) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::platformProcessDidResume() | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::platformTerminate() | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
void NetworkProcess::platformPrepareToSuspend(CompletionHandler<void()>&& completionHandler) | ||
{ | ||
notImplemented(); | ||
completionHandler(); | ||
} | ||
|
||
void NetworkProcess::clearDiskCache(WallTime modifiedSince, CompletionHandler<void()>&& completionHandler) | ||
{ | ||
notImplemented(); | ||
} | ||
|
||
} // namespace WebKit |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/* | ||
* Copyright (C) 2019 Haiku, Inc. | ||
* | ||
* Redistribution and use in source and binary forms, with or without | ||
* modification, are permitted provided that the following conditions | ||
* are met: | ||
* 1. Redistributions of source code must retain the above copyright | ||
* notice, this list of conditions and the following disclaimer. | ||
* 2. Redistributions in binary form must reproduce the above copyright | ||
* notice, this list of conditions and the following disclaimer in the | ||
* documentation and/or other materials provided with the distribution. | ||
* | ||
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' | ||
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, | ||
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS | ||
* BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR | ||
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF | ||
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS | ||
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN | ||
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF | ||
* THE POSSIBILITY OF SUCH DAMAGE. | ||
*/ | ||
|
||
#include "config.h" | ||
#include "NetworkProcessMainUnix.h" | ||
|
||
#include "AuxiliaryProcessMain.h" | ||
#include "NetworkProcess.h" | ||
|
||
namespace WebKit { | ||
|
||
template<> | ||
void initializeAuxiliaryProcess<NetworkProcess>(AuxiliaryProcessInitializationParameters&& parameters) | ||
{ | ||
static NeverDestroyed<NetworkProcess> networkProcess(WTFMove(parameters)); | ||
} | ||
|
||
int NetworkProcessMainUnix(int argc, char** argv) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not use the existing NetworkProcessMainUnix? When the UNIX code works; there is no need to copy it, and copying it and changing copyright on it is not right (you should keep the original copyright when you make changes and add the haiku copyright as well) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only declaration is provided by Unix we have to define it for our own platform hence this |
||
{ | ||
return AuxiliaryProcessMain<NetworkProcess, AuxiliaryProcessMainBase>(argc, argv); | ||
} | ||
|
||
} // namespace WebKit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that the changes in WebCore do not build the WebKitLegacy build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing webcore doesnt build webkitlegacy? i thought all the linked files would be rebuilt again not sure let me build again and let you know 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can build DumpRenderTree or HaikuLauncher (ninja HaikuLauncher) to test building just the webkitlegacy parts. Since WebKit2 build is broken the build may stop before or after building webkit...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is absolutely safe Pulkomandy 😄