Fixed missing headers from Webcore for Webkit2 #8

RAJAGOPALAN-GANGADHARAN · 2019-02-10T14:01:52Z

Fixed some of the missing headers for the day
Next target is Webkit itself

pulkomandy · 2019-02-10T20:00:31Z

Source/WebKit/Platform/haiku/WorkQueueHaiku.cpp

-    along with this library; see the file COPYING.LIB.  If not, write to
-    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
-    Boston, MA 02110-1301, USA.
+ * Copyright (C) 2016 Haiku, Inc. All rights reserved.


I'm curious about this file, where does it come from? Why is the copyright year 2016?

am sorry @pulkomandy i was trying to fix workqueue initially it had not implemented functions. But when i saw about workqueue i found it should be under web template framework as it is the one which handles threads and stuff. so got confused little bit 😅

i will restore this part right now!

Ah, yes, this was moved from WebKit to WTF. So this file can be deleted, then?

yeah i guess workqueue is handled by wtf so no need in webkit right?

pulkomandy · 2019-02-10T20:01:25Z

Source/WebKit/PlatformHaiku.cmake

@@ -131,3 +131,14 @@ add_definitions(
    -DNETWORKPROCESSNAME=\"NetworkProcess\"
 )

+set(WebKit_FORWARDING_HEADERS_DIRECTORIES
+   shared/API/c
+


Please don't leave empty lines here

pulkomandy · 2019-02-10T20:01:46Z

Source/WebKit/Shared/ShareableBitmap.h

@@ -41,7 +41,8 @@
 #endif

 #if PLATFORM(HAIKU)
-#include "graphics/haiku/StillImageHaiku.h"
+//#include "graphics/haiku/StillImageHaiku.h"


You can remove this commented line

stippi

The work queue implementation seems to be sound.

pulkomandy · 2019-02-15T14:52:39Z

Source/WebCore/platform/graphics/FloatPoint.h

@@ -26,6 +26,7 @@

 #pragma once

+#include "AffineTransform.h"


Usually I try to get this working without modifying the WebKit and WebCore headers.
My solution is to move WebKit and webcore includes to local includes in the CMakeLists (you can see how this is done in PlatformHaiku.cmake for WebKitLegacy).
This way, the include with quotes will include WebKit header, and the include with brackets will include Haiku headers

@pulkomandy ur saying about local include directories?

@pulkomandy i did this because to avoid the forward declaration problem that was stopping the build!
If i understood correctly affinetransform.h is referring to haiku header? but i could only find a common header 😅

In this case it is referring to the WebCore header, but if you do nothing special, #include "AffineTransform.h" will include the Haiku header instead, and the build will be confused.

pulkomandy · 2019-02-15T14:53:36Z

Source/WebCore/platform/graphics/transforms/AffineTransform.h

@@ -71,6 +72,10 @@ class AffineTransform {
    AffineTransform(const D2D1_MATRIX_3X2_F&);
 #endif

+#if PLATFORM(HAIKU)
+	AffineTransform(const BAffineTransform&);


I would prefer this was not here, or at least marked explicit to avoid accidentally converting between the two (it could be a performance problem). There are already functions to convert between the two types where needed.

@pulkomandy so including webkit headers would have BAffineTransform within?

No, if you do this:

#include "AffineTransform.h" // get the WebCore header
#include <AffineTransform.h> // get the Haiku header

There are several other cases of similar header clashes in the codebase, which is the reason for introducing LOCAL_INCLUDE_DIRECTORIES in the CMakeLists. The same change can be applied in the CMakeLists for WebKit(2)

pulkomandy · 2019-02-15T16:23:09Z

Source/WTF/wtf/CurrentTime.h

@@ -0,0 +1,86 @@
+/*


Why is this new file needed? Wasn't it moved elsewhere?

But this file is under performance tests but building required this file . So i moved it here.
🤔

pulkomandy · 2019-02-19T21:38:01Z

Hi,

I have rebased your changes and pushed them to the webkit2 branch, with some fixes. I stopped at an issue I don't know how to solve, so your turn to investigate!

The changes I made should give you an idea how various problems can be fixed.

I think the CMakeLists.txt in WebKit/ is out of date, so maybe compare it with the current version in github.com/webkit/webkit and decide which changes are relevant, and which should be dropped. This also applies potentially to all files in the WebKit directory, if in doubt, make sure they are in sync with the versions in the upstream webkit repository.

I have included some extra notes about what I did in the commit message. Don't hesitate to rework your commits (using git rebase -i for example), so that the overall history makes sense. It is easier to follow if a commits does not reverse what was done in the previous one :)

pulkomandy · 2019-02-24T16:26:25Z

Source/WebKit/UIProcess/API/C/WKContextPrivate.h

@@ -31,6 +31,8 @@

 #if defined(WIN32) || defined(_WIN32)
 typedef int WKProcessID;
+#elif PLATFORM(HAIKU)
+typedef int32_t WKProcessID;


This is not right, pid_t should be used for WKProcessID. Adjust the places where it is encoded/decoded if needed.

As far as i know WTF::ProcessID should be same as WKProcessID . We gave WTF::ProcessID as int32_t explicitly so there is ambuiguity rised in function definitions because WKProcessID is of pid_t.
So u think setting WKPRocessID to int32_t explicitly like we did for WTF::processid is viable solution?

I think it would be better to keep pid_t and use the toPid/toProcessId functions I added to convert between the two types?

But if that does not work, yes, we will need this change. In this case I wonder why the code does not use WTF::ProcessID here and defines a different type...

I was wondering the same 😕 . We need not use converting right as having int32_t is simple and viable solution will not introduce much merge conflicts what say?

In this case we have found a real problem in WebKit code, and we will send them the change. So we can make more modifications, and once they have accepted the patch, there will be no merge conflict.

So can i right away explicitly convert to int32_t the WKProcessID?
I asked the webkit-dev still now there was no response so when they suggest something better we better adapt that

They already replied to my mail previously and you asked the same question again. Surely they will find this boring and will not reply a second time.

As I said, I added the toPid/toProcessId functions so we can use them to convert between WKProcessID (pid_t) and WTF::ProcessID (int32_t) and back

pulkomandy · 2019-02-24T16:26:48Z

Source/WebKit/UIProcess/API/C/WKPagePrivate.h

@@ -31,6 +31,8 @@

 #if defined(WIN32) || defined(_WIN32)
 typedef int WKProcessID;
+#elif PLATFORM(HAIKU)
+typedef int32_t WKProcessID;


same here (and why is this enum repeated anyways?)

pulkomandy · 2019-02-24T16:27:23Z

Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.cpp

@@ -2077,7 +2077,7 @@ WebsiteDataStoreParameters WebsiteDataStore::parameters()
        SandboxExtension::createHandleForReadWriteDirectory(parameters.serviceWorkerRegistrationDirectory, parameters.serviceWorkerRegistrationDirectoryExtensionHandle);
 #endif

-    platformSetNetworkParameters(parameters);
+    //platformSetNetworkParameters(parameters);


Please do not edit generic WebKit headers, unless they are out of sync with upstream webkit code because of an earlier merge problem.

@pulkomandy i was trying to debug thats why commented it . iforgot to revert it back 😕 sorry.

RAJAGOPALAN-GANGADHARAN · 2019-02-24T16:34:51Z

Source/WTF/wtf/ProcessID.h

@@ -36,7 +36,9 @@
 namespace WTF {

 #if OS(WINDOWS)
-using ProcessID = int;
+using ProcessID = int; 
+#elif PLATFORM(HAIKU)


@pulkomandy this is also not allowed? should i use pid_t and cast it to int32_t?

@pulkomandy alright it is also un conventional so let me fix by casting itself 😄

@pulkomandy am i allowed to add casting in generic file if so where can i add?

In this case, we are forced to change generic files anyways. (ProcessID.h is also a generic file :))
So, let's add the cast, or maybe add specific calls to the decoders/encoders to encode/decode a pid_t. I don't know which solution is preferred, I will ask webkit-dev.

I have pushed a work in progress implementation which does what I think the WebKit developers want (but I'm not sure). I did not get the "decode" part working yet. I think you can work from that (unless they changed their mind while I was sleeping).

pulkomandy · 2019-02-25T22:37:39Z

Hi,

Today I cleaned up your commits to not have one undoing another, removed some changes I think are incorrect (to AffineTransform, and introduction of CurrentTime.h in wtf which doesn't exist in upstream webkitm for example).

I have changed the ProcessID implementation again, I think this is what Sam Weining meant on the webkit mailing list, however the conversion macros are not used because implicit conversion will work.

Currently the build fails with:

../../Source/WebKit/NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:92:32: error: 'CustomProtocol' has not been declared
uint64_t addCustomProtocol(CustomProtocol&&);

…ader fixes

pulkomandy · 2019-03-07T07:10:03Z

Source/WebKit/Shared/haiku/WebEventFactory.h

@@ -0,0 +1,21 @@
+/*
+license


there is a standard license for webkit, please use it in all files you create:

https://trac.webkit.org/export/242591/webkit/trunk/Source/WebCore/LICENSE-APPLE

of course replace copyright years and assign copyright either to yourself or to Haiku, inc, not to Apple.

RAJAGOPALAN-GANGADHARAN · 2019-03-09T18:23:36Z

Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp

 #include <pal/crypto/gcrypt/Initialization.h>
-#endif
+#endif*/


This is the error i told that day the compiler couldnt identify USE maybe its because the source is happening in a seperate process?

RAJAGOPALAN-GANGADHARAN · 2019-03-09T18:24:24Z

Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp

@@ -227,6 +230,12 @@ bool WebFrameLoaderClient::shouldUseCredentialStorage(DocumentLoader*, unsigned
    return webPage->injectedBundleResourceLoadClient().shouldUseCredentialStorage(*webPage, *m_frame, identifier);
 }

+bool WebFrameLoaderClient::dispatchDidReceiveInvalidCertificate(WebCore::DocumentLoader*, const WebCore::CertificateInfo&, const char* message)


should i also add if directive to check if its haiku?

RAJAGOPALAN-GANGADHARAN · 2019-03-09T18:25:37Z

Source/WebKit/WebProcess/WebCoreSupport/haiku/WebFrameNetworkingContext.cpp

-    notImplemented();
-    return nullptr;
-}
-


I deleted it accidentally and moved it in back but its showing deleted 😞 .

RAJAGOPALAN-GANGADHARAN · 2019-03-09T18:27:53Z

Source/WebKit/Shared/haiku/WebCoreArgumentCodersHaiku.cpp

 {
    notImplemented();
    return false;
 }

-void ArgumentCoder<ResourceResponse>::encodePlatformData(ArgumentEncoder& encoder, const ResourceResponse& resourceResponse)
+/*void ArgumentCoder<ResourceResponse>::encodePlatformData(Encoder& encoder, const ResourceResponse& resourceResponse)


this one doesnt have a matching template in webcoderarguement. so shall i add a template for resourceresponse ? i suppose other platforms dont use resourceresponse so i commented it .

There is a resourceError template i think it covers response? what say

RAJAGOPALAN-GANGADHARAN · 2019-03-09T18:28:05Z

Source/WebKit/Shared/haiku/WebCoreArgumentCodersHaiku.cpp

 {
    //encoder << static_cast<uint32_t>(resourceResponse.soupMessageFlags());
 }

-bool ArgumentCoder<ResourceResponse>::decodePlatformData(ArgumentDecoder& decoder, ResourceResponse& resourceResponse)
+bool ArgumentCoder<ResourceResponse>::decodePlatformData(Decoder& decoder, ResourceResponse& resourceResponse)
 {


same as above

pulkomandy · 2019-03-13T14:02:27Z

Source/WebKit/NetworkProcess/haiku/NetworkProcessMainHaiku.cpp

+    static NeverDestroyed<NetworkProcess> networkProcess(WTFMove(parameters));
+}
+
+int NetworkProcessMainUnix(int argc, char** argv)


Why not use the existing NetworkProcessMainUnix? When the UNIX code works; there is no need to copy it, and copying it and changing copyright on it is not right (you should keep the original copyright when you make changes and add the haiku copyright as well)

Only declaration is provided by Unix we have to define it for our own platform hence this

pulkomandy · 2019-03-13T14:03:21Z

Source/WebKit/WebProcess/haiku/WebProcessMainHaiku.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2014 Haiku, inc.
+ * Copyright 2019 Haiku, Inc.


pulkomandy · 2019-03-13T14:04:34Z

Source/WebCore/platform/graphics/haiku/ImageBufferHaiku.cpp

@@ -32,8 +32,8 @@
 #include "MIMETypeRegistry.h"
 #include "NotImplemented.h"
 #include "StillImageHaiku.h"
-#include "JavaScriptCore/GenericTypedArrayViewInlines.h"
-#include "JavaScriptCore/JSGenericTypedArrayView.h"
+#include "JavaScriptCore/JSCInlines.h"


Have you checked that the changes in WebCore do not build the WebKitLegacy build?

Changing webcore doesnt build webkitlegacy? i thought all the linked files would be rebuilt again not sure let me build again and let you know 😄

you can build DumpRenderTree or HaikuLauncher (ninja HaikuLauncher) to test building just the webkitlegacy parts. Since WebKit2 build is broken the build may stop before or after building webkit...

This change is absolutely safe Pulkomandy 😄

pulkomandy · 2019-03-13T14:06:27Z

Source/WebKit/UIProcess/haiku/WebView.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2013 Intel Corporation. All rights reserved.


Previous copyright should be kept if the file was initially a copy of the work done for another platform.

…webkit into webkit2

…string Note:destructors not handled yet

…of posting a message to main run loop

RAJAGOPALAN-GANGADHARAN · 2019-04-30T12:57:13Z

Source/WTF/wtf/haiku/RunLoopHaiku.cpp

@@ -100,7 +100,7 @@ void RunLoop::run()
 	looper->LockLooper();
 	looper->AddHandler(current().m_handler);
 	looper->UnlockLooper();
-
+	


i will get the spacing and weird debug messages out as now my only aim is to get it rendering 😄

pulkomandy · 2019-04-30T13:49:42Z

Source/WTF/wtf/haiku/RunLoopHaiku.cpp

@@ -115,7 +115,8 @@ void RunLoop::stop()

 void RunLoop::wakeUp()
 {
-    m_handler->Looper()->PostMessage('loop', m_handler);
+	RunLoop::current().performWork();


Uh, this look completely wrong!
RunLoop::wakeUp is called from other threads to wake up the loop.
performWork should be run inside the main loop thread.

There is nothing to win in taking such shortcuts. You will only get things to crash in very strange ways.

Also, this probably breaks existing use of runloop in WebKitLegacy. It would be great if I could merge your changes in the main branch, but with changes like this, it's not going to work.

Sorry just was curious what happens beyond this point 😢 but i knew it is going to break things i will find howto make it work.

pulkomandy · 2019-04-30T13:50:01Z

Source/WebCore/PlatformHaiku.cmake

@@ -96,7 +96,7 @@ list(APPEND WebCore_SOURCES
  platform/graphics/texmap/GraphicsLayerTextureMapper.cpp
  platform/graphics/texmap/TextureMapperImageBuffer.cpp

-  platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp
+  #platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp


What's the problem with this file?

This file does not do anything everything is wrapped under USE(COORDINATEDGRAPHICS) while we have disabled it so thought it would be a good clean up 😅😅

pulkomandy · 2019-04-30T13:50:31Z

Source/WebCore/platform/network/haiku/HaikuFormDataStream.cpp

@@ -117,7 +117,7 @@ WTF::Optional<size_t> BFormDataIO::readFromFile(const FormDataElement::EncodedFi
        m_fileHandle = FileSystem::openFile(fileData.filename, FileSystem::FileOpenMode::Read);

    if (!FileSystem::isHandleValid(m_fileHandle)) {
-        LOG(Network, "Haiku - Failed while trying to open %s for upload\n", fileData.filename.utf8().data());
+        //LOG(Network, "Haiku - Failed while trying to open %s for upload\n", fileData.filename.utf8().data());


Why? Is it just a missing include to define the LOG macro?

pulkomandy · 2019-04-30T13:52:37Z

Source/WebKit/UIProcess/API/haiku/WebView.cpp

+	{
+		fprintf(stderr,"its painting\n");
+		WebCore::Region unpainted;
+		BView* surface = new BView("drawing_surface",B_WILL_DRAW);


BWebView is a BView, and it's the one you should draw on. Here you are creating a new BView every time this is called, which is a huge memory leak, and you are not going to draw anything onto the BWebView itself.

Oops im still learning so please forgive me. I do understand that it is wrong now. Uh how can i miss it out I am supposed to use the existing view to draw but im just overlaying it over and over.

pulkomandy · 2019-04-30T13:53:16Z

Source/WebKit/UIProcess/Launcher/haiku/ProcessLauncherHaiku.cpp

@@ -26,12 +26,83 @@
 #include "config.h"
 #include "ProcessLauncher.h"

+#define __STDC_FORMAT_MACROS


Is this still needed?

Yes to get uint64 into a string(as a format specifier) we need this

pulkomandy · 2019-04-30T13:56:22Z

Source/WebKit/UIProcess/MiniBrowser.entitlements

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>


What's this file?

I think its like a configuration file created by webkit for mini browser

pulkomandy · 2019-04-30T13:57:11Z

Source/WebKit/WebProcess/haiku/WebProcessMainHaiku.cpp

@@ -39,13 +39,15 @@ class WebProcessMain final : public AuxiliaryProcessMainBase {
 public:
    bool platformInitialize() override
    {
-        BApplication* app = new BApplication("application/x-vnd.haiku-webkit.webprocess");


You really need a BApplication to do anything. Where is it created, if not here?

The ui process is a bapplication right wont that suffice?

No. Without the BApplication, 1) the worker will have no link to the app_server for things like drawing ops, and 2) It won't be registered with the roster, and consequently you'd have no way of sending e.g. BMessages between it and the UI process.

I see so that explains why my messages were not recieved

so this will be my main run loop that gets all my messages right?

For inter-process communications, yes.

Yes. I think the runloop implementation detects that it is in the main thread, and in that cases it will run the BApplication looper (using be_app->Run()). Otherwise (for various worker threads) it will create its own worker instead.

…ructure

…wind and lldb. https://bugs.webkit.org/show_bug.cgi?id=205050 Reviewed by Michael Saboff. Before this patch, the stack trace from inside a probe function is cut off at ctiMasmProbeTrampoline: (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef) ... frame #4: 0x0000000100824607 JavaScriptCore`WTF::Function<void (JSC::Probe::Context&)>::operator(this=0x000000010b88bd00, in=0x00007ffeefbfd400)(JSC::Probe::Context&) const at Function.h:79:35 frame #5: 0x0000000100823996 JavaScriptCore`JSC::stdFunctionCallback(context=0x00007ffeefbfd400) at MacroAssembler.cpp:53:5 frame #6: 0x000000010082701e JavaScriptCore`JSC::Probe::executeProbe(state=0x00007ffeefbfd480) at ProbeContext.cpp:51:5 frame #7: 0x000000010082614b JavaScriptCore`ctiMasmProbeTrampoline + 299 (lldb) After this patch, we'll now get the full stack trace from inside the probe function: (lldb) bt * thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, address=0xbbadbeef) ... frame #4: 0x0000000100826d17 JavaScriptCore`WTF::Function<void (JSC::Probe::Context&)>::operator(this=0x0000000106b878f8, in=0x00007ffeefbfd400)(JSC::Probe::Context&) const at Function.h:79:35 frame #5: 0x0000000100826106 JavaScriptCore`JSC::stdFunctionCallback(context=0x00007ffeefbfd400) at MacroAssembler.cpp:53:5 frame #6: 0x000000010082986e JavaScriptCore`JSC::Probe::executeProbe(state=0x00007ffeefbfd480) at ProbeContext.cpp:51:5 frame #7: 0x00000001008289a2 JavaScriptCore`ctiMasmProbeTrampoline + 338 frame #8: 0x0000466db28025be frame #9: 0x0000000100754ffc JavaScriptCore`llint_entry at LowLevelInterpreter.asm:994 frame #10: 0x0000000100738173 JavaScriptCore`vmEntryToJavaScript at LowLevelInterpreter64.asm:307 frame #11: 0x0000000101489307 JavaScriptCore`JSC::JITCode::execute(this=0x0000000106ba1520, vm=0x0000000106d00000, protoCallFrame=0x00007ffeefbfd9b8) at JITCodeInlines.h:38:38 frame #12: 0x0000000101488982 JavaScriptCore`JSC::Interpreter::executeProgram(this=0x0000000106bfd1f8, source=0x00007ffeefbff090, (null)=0x000000010d0e0000, thisObj=0x000000010d0e8020) at Interpreter.cpp:847:51 frame #13: 0x00000001017d1f9c JavaScriptCore`JSC::evaluate(globalObject=0x000000010d0e0000, source=0x00007ffeefbff090, thisValue=JSValue @ 0x00007ffeefbfef60, returnedException=0x00007ffeefbff0b0) at Completion.cpp:146:38 frame #14: 0x000000010005838f jsc`runWithOptions(globalObject=0x000000010d0e0000, options=0x00007ffeefbff620, success=0x00007ffeefbff48b) at jsc.cpp:2670:35 frame #15: 0x000000010002a0da jsc`jscmain(this=0x00007ffeefbff5a0, vm=0x0000000106d00000, globalObject=0x000000010d0e0000, success=0x00007ffeefbff48b)::$_6::operator()(JSC::VM&, GlobalObject*, bool&) const at jsc.cpp:3157:13 frame #16: 0x0000000100006eff jsc`int runJSC<jscmain(int, char**)::$_6>(options=0x00007ffeefbff620, isWorker=false, func=0x00007ffeefbff5a0)::$_6 const&) at jsc.cpp:3003:9 frame #17: 0x0000000100005988 jsc`jscmain(argc=10, argv=0x00007ffeefbff6c8) at jsc.cpp:3150:18 frame #18: 0x000000010000575e jsc`main(argc=10, argv=0x00007ffeefbff6c8) at jsc.cpp:2498:15 frame #19: 0x00007fff6cfc4da9 libdyld.dylib`start + 1 frame #20: 0x00007fff6cfc4da9 libdyld.dylib`start + 1 (lldb) The difference is that the x86_64 ctiMasmProbeTrampoline now uses the standard function prologue, and keeps %rbp pointing to trampoline function's semblance of a frame that libunwind can understand while it calls the probe function. * assembler/MacroAssemblerX86Common.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@253320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Building webkit command fix

d883420

pulkomandy reviewed Feb 10, 2019

View reviewed changes

stippi reviewed Feb 11, 2019

View reviewed changes

pulkomandy reviewed Feb 15, 2019

View reviewed changes

pulkomandy force-pushed the webkit2 branch from d7b0fc8 to 01e8fac Compare February 19, 2019 21:32

pulkomandy suggested changes Feb 24, 2019

View reviewed changes

RAJAGOPALAN-GANGADHARAN commented Feb 24, 2019

View reviewed changes

pulkomandy force-pushed the webkit2 branch from 5916107 to 82a8d11 Compare February 25, 2019 22:27

RAJAGOPALAN-GANGADHARAN added 3 commits March 3, 2019 14:56

Merge remote-tracking branch 'upstream/webkit2' into HEAD

42addb5

Restored haikus NetworkContext to latest state

6fdad02

Created WebEvent factory and some fixes for old haiku APIs and few he…

09f7990

…ader fixes

pulkomandy reviewed Mar 7, 2019

View reviewed changes

RAJAGOPALAN-GANGADHARAN added 2 commits March 9, 2019 05:14

Few more build fixes

7e97e5b

Fixed few linking errors

1b9e6ac

RAJAGOPALAN-GANGADHARAN commented Mar 9, 2019

View reviewed changes

More linking errors fixed

31351ab

pulkomandy reviewed Mar 13, 2019

View reviewed changes

RAJAGOPALAN-GANGADHARAN added 4 commits March 13, 2019 19:40

Update WebProcessMainHaiku.cpp

5e05c55

Roll back licence info

2cd19e0

Fixed building webkit2

81a496a

Cleanup job

0d98b04

RAJAGOPALAN-GANGADHARAN added 4 commits March 17, 2019 08:40

Configuring minibrowser build and execute [early stage]

4a7a146

Merge branch 'webkit2' of https://github.com/RAJAGOPALAN-GANGADHARAN/…

c80ae31

…webkit into webkit2

Initial implementation to load blank url and now trying to load html …

c9f0fd0

…string Note:destructors not handled yet

Process launching done succesffuly but for now have ignored the case …

7182b92

…of posting a message to main run loop

RAJAGOPALAN-GANGADHARAN commented Apr 30, 2019

View reviewed changes

pulkomandy reviewed Apr 30, 2019

View reviewed changes

RAJAGOPALAN-GANGADHARAN added 2 commits May 2, 2019 01:32

Added message handler to main run loop and made changes to webview st…

1e1c1ad

…ructure

Fixed naming and namespace inconsistencies

7fc2bc0

pulkomandy merged commit b0584fd into haiku:webkit2 May 6, 2019

		@@ -1,5 +1,5 @@
		/*
		* Copyright (C) 2013 Intel Corporation. All rights reserved.

Fixed missing headers from Webcore for Webkit2 #8

Fixed missing headers from Webcore for Webkit2 #8

Conversation

RAJAGOPALAN-GANGADHARAN commented Feb 10, 2019

pulkomandy Feb 10, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stippi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

RAJAGOPALAN-GANGADHARAN Feb 15, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulkomandy commented Feb 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulkomandy Feb 27, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulkomandy commented Feb 25, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pulkomandy Feb 10, 2019 •

edited

RAJAGOPALAN-GANGADHARAN Feb 15, 2019 •

edited

pulkomandy Feb 27, 2019 •

edited