Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing word on developing page #30

Merged
merged 1 commit into from Feb 20, 2017
Merged

Fix missing word on developing page #30

merged 1 commit into from Feb 20, 2017

Conversation

kainjow
Copy link
Contributor

@kainjow kainjow commented Feb 20, 2017

No description provided.

@waddlesplash waddlesplash merged commit ecc5083 into haiku:master Feb 20, 2017
@waddlesplash
Copy link
Member

Thanks!

@waddlesplash
Copy link
Member

It looks like your changes altered the filemode (100644 => 100755). I fixed it in 8a55b86, so just a heads-up to watch out for that next time.

@kainjow
Copy link
Contributor Author

kainjow commented Feb 21, 2017

Ah, my bad. Do all files need the same permissions? Could chmod them all in the deployment script. That's what I do for my Jenkins sites.

@waddlesplash
Copy link
Member

Do all files need the same permissions? Could chmod them all in the deployment script. That's what I do for my Jenkins sites.

Uh, no, you should just commit them with the right filemodes. Why are files you change or add getting their x bit set anyway?

@kainjow
Copy link
Contributor Author

kainjow commented Feb 21, 2017

Probably the text editor I was using. I certainly didn't manually change it.

It's weird that GH's diff for the patch doesn't show the file mode change, but your commit does.

@kainjow
Copy link
Contributor Author

kainjow commented Feb 21, 2017

Actually, I think I used GitHub's web editor to make the change, which uses the -patch branch name, so maybe it's a GH bug?

@kainjow
Copy link
Contributor Author

kainjow commented Feb 21, 2017

Ok, it was the c4ccaf7 that changed it. Not sure how that happened, I'll try to watch for it next time.

@kainjow kainjow deleted the patch-1 branch February 24, 2017 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants