Fixed dark mode issues #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made text colour black for the Installation Guide steps so the text is visible in dark mode.
Fixed issues in dark mode on the installation guide and the Get Haiku! page.
Update copyright date
Fixed port status page dark mode display issues, plus added table hover effects.
|
Would be really appreciated if someone reviewed this! |
humdingerb
reviewed
Jun 25, 2021
Restore key spans as suggested by @humdingerb
|
@humdingerb I've just restored the key spans. |
|
OK. I still have no clue about dark mode, so I'm outta here... |
leavengood
requested changes
Jul 10, 2021
|
Yes, the browser has a way to say "I'm using dark mode" and the CSS can query that and use different colors depending on it. In other browsers it's probably an option somewhere in preferences. |
jt15s
added a commit
to jt15s/website
that referenced
this pull request
Jul 13, 2021
Add link classes to ensure table is visible (though this is dependent on haiku#521 passing) and reverted change of graphic to Beta2 download button to prevent any confusion once this is merged.
Co-authored-by: Ryan Leavengood <leavengood@gmail.com>
|
Looks like this has a conflict with the shijin4.css file in master - could one of the repo maintainers fix this please and merge if there are no remaining issues? Thanks in advance! |
leavengood
added a commit
that referenced
this pull request
Jul 13, 2021
* Added tags to blog posts and added WIP pages for Beta 3 release details Added tags to some of the blog posts related to the Haiku Promotion Team, and also added WIP release pages for Beta 3 (based on the ones for Beta 2) - these have been marked as "draft=true" so Hugo will not publish these. Feel free to add any info/corrections! * Update release-notes.md Made improvements as suggested by @nielx * Updated Getting Involved system page and ports status page Updated the Getting Involved system page to remove outdated parts, and added X512's RISC-V port to the ports status page. * Update GET_HAIKU.PNG Updated download button graphic for Beta3. * Update social-media.md Resolved a merge conflict. * Update port_status.html Fixed wrong target names. Thanks @X547 for pointing that out! * Update _index.md Added warning/info boxes. * Update release-notes.md Added to-do items plus info boxes. * Update _index.md Fixed formatting typos with info boxes. * Update README.md Added info on running scripts on Windows. * Update Beta3 pages Add link classes to ensure table is visible (though this is dependent on #521 passing) and reverted change of graphic to Beta2 download button to prevent any confusion once this is merged. Co-authored-by: Ryan Leavengood <leavengood@gmail.com>
kallisti5
pushed a commit
to kallisti5/website
that referenced
this pull request
Jan 2, 2022
* Update shijin4.css Update copyright date Made text colour black for the Installation Guide steps so the text is visible in dark mode. * Fixed dark mode issues Fixed issues in dark mode on the installation guide and the Get Haiku! page. * Fix port status page dark mode issues Fixed port status page dark mode display issues, plus added table hover effects. * Update installation-guide.html Restore key spans as suggested by @humdingerb * Update content/get-haiku/installation-guide.html
kallisti5
pushed a commit
to kallisti5/website
that referenced
this pull request
Jan 2, 2022
* Added tags to blog posts and added WIP pages for Beta 3 release details Added tags to some of the blog posts related to the Haiku Promotion Team, and also added WIP release pages for Beta 3 (based on the ones for Beta 2) - these have been marked as "draft=true" so Hugo will not publish these. Feel free to add any info/corrections! * Update release-notes.md Made improvements as suggested by @nielx * Updated Getting Involved system page and ports status page Updated the Getting Involved system page to remove outdated parts, and added X512's RISC-V port to the ports status page. * Update GET_HAIKU.PNG Updated download button graphic for Beta3. * Update social-media.md Resolved a merge conflict. * Update port_status.html Fixed wrong target names. Thanks @X547 for pointing that out! * Update _index.md Added warning/info boxes. * Update release-notes.md Added to-do items plus info boxes. * Update _index.md Fixed formatting typos with info boxes. * Update README.md Added info on running scripts on Windows. * Update Beta3 pages Add link classes to ensure table is visible (though this is dependent on haiku#521 passing) and reverted change of graphic to Beta2 download button to prevent any confusion once this is merged. Co-authored-by: Ryan Leavengood <leavengood@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issues in dark mode on the installation guide and the Get Haiku! page.