Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamRadio Missing symbol: _ZN11BUrlRequest5PauseEv #6123

Closed
smallstepforman opened this issue Aug 8, 2021 · 7 comments
Closed

StreamRadio Missing symbol: _ZN11BUrlRequest5PauseEv #6123

smallstepforman opened this issue Aug 8, 2021 · 7 comments

Comments

@smallstepforman
Copy link
Contributor

With hrev55294, SteamRadio will not start, and comes up with BAlert "Could not open "Stream Radio" (Missing symbol: _ZN11BUrlRequest5PauseEv).

@smallstepforman
Copy link
Contributor Author

Sorry, should have added the bug report to https://github.com/HaikuArchives/StreamRadio

@X547
Copy link
Contributor

X547 commented Aug 8, 2021

@korli
Copy link
Contributor

korli commented Aug 9, 2021

actually the bug report would go to the Haiku bug tracker. the symbols should be kept private for compatibility

@smallstepforman
Copy link
Contributor Author

In Haiku's defence, it is a private API, so no guarantees about ABI compatibility.
For another project which used BUrlRequest, I had to bump my program due to API change. It is a private API so I wasn't too annoyed by the refactoring effort ...

@korli
Copy link
Contributor

korli commented Aug 9, 2021

here the problem is the buildbot builds against beta3 Haiku packages, and nightly Haiku package says: "I'm compatible with beta3", accepts to install StreamRadio built for beta3, and refuses to run it.

@pulkomandy
Copy link
Member

Yes, I removed some methods from classes, thinking that it would only affect the version that's in the static library with the private API. But it also affects the deprecated (kept for compatibility) shared library version.

So there are two things to fix:

  • In Haiku, restore the pause and resume functions, but only for the deprecated shared version
  • In StreamRadio, migrate to the private, statically linked version of the API to avoid the problem and be ready for future Haiku updates

@pulkomandy
Copy link
Member

Haiku side fixed in hrev55310.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants