Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Midnight Commander] Suggestion: switch from ncurses to slang-2.3.2 #6849

Closed
OscarL opened this issue Apr 24, 2022 · 4 comments · Fixed by #6953
Closed

[Midnight Commander] Suggestion: switch from ncurses to slang-2.3.2 #6849

OscarL opened this issue Apr 24, 2022 · 4 comments · Fixed by #6953

Comments

@OscarL
Copy link
Contributor

OscarL commented Apr 24, 2022

Now that Haiku's Terminal supports 24 bit colors, maybe Midnight Commander could switch from being built with --with-screen=ncurses to --with-screen=slang in order to be able to use true-color themes.

This issue might get in the way, but seems fairly minor.

BTW... any idea about why box-drawing characters are not used/enabled/working on the current mc Haiku port?
@augiedoggie
Copy link
Contributor

I'm having trouble getting this to link properly with slang. I might push an update to fix a few problems with the mc recipe but there are still issues with it.

BTW... any idea about why box-drawing characters are not used/enabled/working on the current mc Haiku port?

Have you tried a different font? mc looks identical between Haiku and Linux with both using a Source Code Pro font

@OscarL
Copy link
Contributor Author

OscarL commented May 17, 2022

Have you tried a different font? mc looks identical between Haiku and Linux with both using a Source Code Pro font

I have not tried changing fonts, no. Thanks for pointing that out! I'll try with the font you mention (and if that works... I guess I should file a ticket on dev.haiku-os.org regarding box drawing not (fully) working with the default Terminal fonts?).

Thanks for taking a look at this, much appreciated!

augiedoggie added a commit to augiedoggie/haikuports that referenced this issue May 17, 2022
@augiedoggie
mc: use slang, fix deps, improve Haiku patches
b4aae14 
fixes haikuports#6849

The libncurses link had to be forced via the LIBS variable.  I'm not
sure if the problem is with mc or slang.
@augiedoggie
Copy link
Contributor

screenshot1
I did get it to build with slang. I submitted a pull request and I'll give it a day to see if anyone has comments.

augiedoggie added a commit to augiedoggie/haikuports that referenced this issue May 28, 2022
@augiedoggie
mc: use slang, fix deps, improve Haiku patches
347dfa0 
fixes haikuports#6849
@augiedoggie augiedoggie mentioned this issue May 28, 2022
Merged
augiedoggie added a commit that referenced this issue May 28, 2022
@augiedoggie
mc: use slang, fix deps, improve Haiku patches (#6953)
83b12d3 
fixes #6849
@OscarL
Copy link
Contributor Author

OscarL commented May 29, 2022

Working alright down here! Even the doble-lines box drawing characters, awesome!

Thank you @augiedoggie! Really appreciated.

Regarding my comment of box-drawing not working before... Changing the font to Source Code Pro shows that the issue is indeed in the font drawing (Noto Mono seems to have too many vertical space separation for some characters).

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mc: use slang, fix deps, improve Haiku patches augiedoggie/haikuports
2 participants
@augiedoggie @OscarL