Otter browser: new recipe #1006
Conversation
|
Does it work? |
| " | ||
| REQUIRES=" | ||
| haiku$secondaryArchSuffix | ||
| hunspell$secondaryArchSuffix |
There was a problem hiding this comment.
@miqlas, I guess @korli's question mark means: "Why don't you use lib:libhunspell_1.4$secondaryArchSuffix"
Because that's the lib that hunspell-1.4.2 provides.
| REQUIRES=" | ||
| haiku$secondaryArchSuffix | ||
| hunspell$secondaryArchSuffix | ||
| qt5$secondaryArchSuffix |
There was a problem hiding this comment.
lib:libQt5Core$secondaryArchSuffix?
| " | ||
|
|
||
| BUILD_PREREQUIRES=" | ||
| cmd:cmake$secondaryArchSuffix |
| " | ||
| BUILD_REQUIRES=" | ||
| haiku${secondaryArchSuffix}_devel | ||
| hunspell${secondaryArchSuffix}_devel |
| BUILD_REQUIRES=" | ||
| haiku${secondaryArchSuffix}_devel | ||
| hunspell${secondaryArchSuffix}_devel | ||
| qt5${secondaryArchSuffix}_devel |
There was a problem hiding this comment.
devel:libQt5Core$secondaryArchSuffix?
| hunspell${secondaryArchSuffix}_devel | ||
| qt5${secondaryArchSuffix}_devel | ||
| devel:libssl$secondaryArchSuffix | ||
| devel:libcrypto$secondaryArchSuffix |
There was a problem hiding this comment.
These two should definitely come in REQUIRES too.
There was a problem hiding this comment.
@miqlas, when you copy these 2 lines to REQUIRES, don't forget to change the "devel:lib*" into "lib:lib*" to have:
lib:libssl$secondaryArchSuffix
lib:libcrypto$secondaryArchSuffix
| SOURCE_URI="https://github.com/OtterBrowser/otter-browser/archive/v$portVersion.tar.gz" | ||
| CHECKSUM_SHA256="1a184561b9dbf3443cf1f83ad8604976b1b06cc00a93306331b364f237363e20" | ||
| ADDITIONAL_FILES="otter.rdef.in" | ||
| SOURCE_DIR="otter-browser-$portVersion" |
There was a problem hiding this comment.
Please swap SOURCE_DIR and ADDITIONAL_FILES.
Source: HaikuPorter guidelines
| SUMMARY="A lightweight QtWebKit browser" | ||
| DESCRIPTION="Project aiming to recreate the best aspects of the \ | ||
| classic Opera (12.x) UI using Qt5." | ||
| HOMEPAGE="http://otter-browser.org/" |
There was a problem hiding this comment.
https://otter-browser.org/ is available through https (with Let's Encrypt certificates) so you might wish to change HOMEPAGE to:
HOMEPAGE="https://otter-browser.org/"
| " | ||
|
|
||
| BUILD_PREREQUIRES=" | ||
| cmd:cmake$secondaryArchSuffix |
| BUILD_REQUIRES=" | ||
| haiku${secondaryArchSuffix}_devel | ||
| devel:libcrypto$secondaryArchSuffix | ||
| devel:libhunspell-1.4$secondaryArchSuffix |
There was a problem hiding this comment.
Should be
devel:libhunspell_1.4$secondaryArchSuffix
(rule: use "_" for "-")
| make install | ||
|
|
||
| mv $appsDir/Otter-Browser/bin/otter-browser \ | ||
| $appsDir/Otter-Browser/Otter-Browser |
There was a problem hiding this comment.
There is certainly a way to avoid this mv, by passing a parameter to cmake.
There was a problem hiding this comment.
nope, it is defined so in cmakelist.txt, i don't want to use advanced sed magic for this, sorry.
| mkdir -p build | ||
| cd build | ||
|
|
||
| cmake .. -DCMAKE_INSTALL_PREFIX:PATH="$appsDir/Otter\ Browser" |
There was a problem hiding this comment.
Did you mean
cmake .. -DCMAKE_INSTALL_PREFIX:PATH="$appsDir/Otter-Browser"
|
@korli : Yep, it works, but it using the Qt backend for SSL connections, and the current Qt in HaikuDepot doesn't handle them correctly, so it warns all the time about the certificates. |
* Otter Browser: new recipe * Otter browser: additional files * Defined REQs * Reworked recipe, including sed magic * HTTPS homepage
No description provided.