tig: update to version 2.5.8.

[OscarL]

No description provided.

[OscarL]

Last night I ran hp --test tig, only 3 tests failed. Was adding the results to the recipe, and got a power-loss :-/

Hold on on this one 'till I add those tests results later today. DONE.

[OscarL]

For what is worth, this is the output of the failing tests:

PATH=/haikuports/haikuports/dev-vcs/tig/work-2.5.8/sources/tig-2.5.8/test/tools:$PATH ./test/main/emoji-test > tig-emoji-test.txt

WARNING: before running the command above, backup your global git config file, because these tests change git settings globally :-/

            | Failed 3 out of 6 test(s)
            | [FAIL] emoji-commit-titles-col-46.screen != expected/emoji-commit-titles-col-46.screen
            | diff --git a/expected/emoji-commit-titles-col-46.screen b/emoji-commit-titles-col-46.screen
            | index f13b34e..10cb687 100644
            | --- a/expected/emoji-commit-titles-col-46.screen
            | +++ b/emoji-commit-titles-col-46.screen
            | @@ -1,9 +1,9 @@
            | -2009-04-06 01:44 +0000 Committer o [master] 🌏
            | -2009-03-28 13:22 +0000 Committer o 💄 Polish t
            | -2009-03-20 01:00 +0000 Committer o 📚 Document
            | -2009-03-11 12:38 +0000 Committer o 🎨 Reformat
            | +2009-04-06 01:44 +0000 Committer o [master] ~O
            | +2009-03-28 13:22 +0000 Committer o ~D Polish t
            | +2009-03-20 01:00 +0000 Committer o ~Z Document
            | +2009-03-11 12:38 +0000 Committer o M-( Reforma
            |  2009-03-03 00:15 +0000 Committer o ✨ Add new
            | -2009-02-22 11:53 +0000 Committer o 🐧 Fix Linu
            | -2009-02-13 23:31 +0000 Committer I 🚑 Fix bug
            | +2009-02-22 11:53 +0000 Committer o M-' Fix Lin
            | +2009-02-13 23:31 +0000 Committer I ~Q Fix bug
            |   
            |  [main] 237d747db3f85d2ae36127ecd0371feb4ca100%
            |   [OK] emoji-commit-titles-col-46.stderr assertion
            | [FAIL] emoji-commit-titles-col-unset.screen != expected/emoji-commit-titles-col-unset.screen
            | diff --git a/expected/emoji-commit-titles-col-unset.screen b/emoji-commit-titles-col-unset.screen
            | index 6c62c2c..d87a613 100644
            | --- a/expected/emoji-commit-titles-col-unset.screen
            | +++ b/emoji-commit-titles-col-unset.screen
            | @@ -1,9 +1,9 @@
            | -2009-04-06 01:44 +0000 Committer o [master] 🌏💧✋🕋🗡🚀🏜☀🌡🌶💯🚱⏳🌅🌑😡💉😱😈💀
            | -2009-03-28 13:22 +0000 Committer o 💄 Polish the UI
            | -2009-03-20 01:00 +0000 Committer o 📚 Document new feature
            | -2009-03-11 12:38 +0000 Committer o 🎨 Reformat the code
            | +2009-04-06 01:44 +0000 Committer o [master] ~OM-'✋~KM-!~@~\☀M-!M-6M-/M-1⏳~E~QM-!
            | +2009-03-28 13:22 +0000 Committer o ~D Polish the UI
            | +2009-03-20 01:00 +0000 Committer o ~Z Document new feature
            | +2009-03-11 12:38 +0000 Committer o M-( Reformat the code
            |  2009-03-03 00:15 +0000 Committer o ✨ Add new feature
            | -2009-02-22 11:53 +0000 Committer o 🐧 Fix Linux issue
            | -2009-02-13 23:31 +0000 Committer I 🚑 Fix bug
            | +2009-02-22 11:53 +0000 Committer o M-' Fix Linux issue
            | +2009-02-13 23:31 +0000 Committer I ~Q Fix bug
            |   
            |  [main] 237d747db3f85d2ae36127ecd0371feb4ca986e3 - commit 1 of 7             100%
            |   [OK] emoji-commit-titles-col-unset.stderr assertion
            | [FAIL] emoji-commit-titles-col-300.screen != expected/emoji-commit-titles-col-300.screen
            | diff --git a/expected/emoji-commit-titles-col-300.screen b/emoji-commit-titles-col-300.screen
            | index 882be70..49c6047 100644
            | --- a/expected/emoji-commit-titles-col-300.screen
            | +++ b/emoji-commit-titles-col-300.screen
            | @@ -1,9 +1,9 @@
            | -2009-04-06 01:44 +0000 Committer o [master] 🌏💧✋🕋🗡🚀🏜☀🌡🌶💯🚱⏳🌅🌑😡💉😱😈💀💥🌛🌙🐭💥🚶🏻〰🐛⌛👳🙏💥😴🛌😳💥🐛💥👊⚔👑
            | -2009-03-28 13:22 +0000 Committer o 💄 Polish the UI
            | -2009-03-20 01:00 +0000 Committer o 📚 Document new feature
            | -2009-03-11 12:38 +0000 Committer o 🎨 Reformat the code
            | +2009-04-06 01:44 +0000 Committer o [master] ~OM-'✋~KM-!~@~\☀M-!M-6M-/M-1⏳~E~QM-!~IM-1~H~@M-%~[~YM--M-%M-6M-;〰~[⌛M-3~OM-%M-4~LM-3M-%~[M-%~J⚔~Q
            | +2009-03-28 13:22 +0000 Committer o ~D Polish the UI
            | +2009-03-20 01:00 +0000 Committer o ~Z Document new feature
            | +2009-03-11 12:38 +0000 Committer o M-( Reformat the code
            |  2009-03-03 00:15 +0000 Committer o ✨ Add new feature
            | -2009-02-22 11:53 +0000 Committer o 🐧 Fix Linux issue
            | -2009-02-13 23:31 +0000 Committer I 🚑 Fix bug
            | +2009-02-22 11:53 +0000 Committer o M-' Fix Linux issue
            | +2009-02-13 23:31 +0000 Committer I ~Q Fix bug
            |   
            |  [main] 237d747db3f85d2ae36127ecd0371feb4ca986e3 - commit 1 of 7                                                                                                                                                                                                                                         100%
            |   [OK] emoji-commit-titles-col-300.stderr assertion

Of course, on beta4 Terminal I can't see any emoji at all (and trying to copy the output above doesn't seems to work, so I had to redirect it to a file).

Tried using Noto Color Emoji font, but rendering breaks badly on Terminal.

[pulkomandy]

Color fonts are not supported at all by app_server. So at best you can use Noto Emoji (the monochrome version) which should already be in the font fallback path.

It seems strange in the logs that some, but not all, emojis are working. why are they different?

[OscarL]

It seems strange in the logs that some, but not all, emojis are working. why are they different?

This is the source of the test in question:

https://github.com/jonas/tig/blob/master/test/main/emoji-test

And here the libgit.sh helper:

https://github.com/jonas/tig/blob/master/test/tools/libgit.sh

I don't see anything crazy, so no idea why/where those git commit messages are getting garbled. Do we have a broken git ?

Edit: well, even a broken git woudn't explain #10208, so more on the ncursesw side of things?

[Begasus]

Current version had the same problem on the emoticon tests and didn't even succesfully passed all tests (no SUMMARY).