New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assimp, new recipe, wip #1645
Merged
Merged
assimp, new recipe, wip #1645
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
SUMMARY="Importer library to import assets from 3D files" | ||
DESCRIPTION="Open Asset Import Library (short name: Assimp) is a portable \ | ||
Open Source library to import various well-known 3D model formats in a \ | ||
uniform manner. The most recent version also knows how to export 3d files \ | ||
and is therefore suitable as a general-purpose 3D model converter." | ||
HOMEPAGE="https://github.com/assimp/assimp" | ||
COPYRIGHT="2006-2016, assimp team" | ||
LICENSE="BSD (3-clause)" | ||
REVISION="1" | ||
SOURCE_URI="https://github.com/assimp/assimp/archive/v$portVersion.tar.gz" | ||
CHECKSUM_SHA256='60080d8ab4daaab309f65b3cffd99f19eb1af8d05623fff469b9b652818e286e' | ||
|
||
ARCHITECTURES="!x86_gcc2 x86 x86_64" | ||
SECONDARY_ARCHITECTURES="x86" | ||
|
||
PROVIDES=" | ||
assimp$secondaryArchSuffix = $portVersion | ||
cmd:assimp$secondaryArchSuffix | ||
lib:libassimp$secondaryArchSuffix = 4.0.1 compat >= 4 | ||
" | ||
REQUIRES=" | ||
haiku$secondaryArchSuffix | ||
lib:libGL$secondaryArchSuffix | ||
lib:libglu$secondaryArchSuffix | ||
lib:libgomp$secondaryArchSuffix | ||
lib:libminizip$secondaryArchSuffix | ||
lib:libz$secondaryArchSuffix | ||
" | ||
|
||
PROVIDES_devel=" | ||
assimp${secondaryArchSuffix}_devel = $portVersion | ||
devel:libassimp$secondaryArchSuffix = 4.0.1 compat >= 4 | ||
" | ||
REQUIRES_devel=" | ||
assimp$secondaryArchSuffix == $portVersion base | ||
" | ||
|
||
BUILD_REQUIRES=" | ||
haiku${secondaryArchSuffix}_devel | ||
devel:libGL$secondaryArchSuffix | ||
devel:libglu$secondaryArchSuffix | ||
devel:libminizip$secondaryArchSuffix | ||
devel:libz$secondaryArchSuffix | ||
" | ||
BUILD_PREREQUIRES=" | ||
cmd:cmake | ||
cmd:gcc$secondaryArchSuffix | ||
cmd:make | ||
cmd:pkg_config$secondaryArchSuffix | ||
" | ||
|
||
BUILD() | ||
{ | ||
mkdir -p build | ||
cd build | ||
cmake -DASSIMP_BIN_INSTALL_DIR=$binDir \ | ||
-DASSIMP_LIB_INSTALL_DIR=$libDir \ | ||
-DASSIMP_INCLUDE_INSTALL_DIR=$includeDir .. | ||
make $jobArgs | ||
} | ||
|
||
INSTALL() | ||
{ | ||
cd build | ||
make install | ||
|
||
prepareInstalledDevelLib libassimp | ||
|
||
fixPkgconfig | ||
|
||
packageEntries devel \ | ||
$developDir | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These INSTALL_DIR could theorically be replaced by $cmakeDirArgs, provided that https://github.com/assimp/assimp/blob/master/CMakeLists.txt#L186 is extended: if( UNIX or HAIKU )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to look into this how to use it ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be: cmake $cmakeDirArgs ..
provided that https://github.com/assimp/assimp/blob/master/CMakeLists.txt#L186 is extended: if( UNIX or HAIKU )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the part of " cmake $cmakeDirArgs .. ", just not sure how to extend the correct way of extending ( UNIX or HAIKU ) ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS, not too familiar with cmake myself ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@korli: arent't we UNIX for cmake already?
https://gitlab.kitware.com/cmake/cmake/blob/master/Modules/Platform/Haiku.cmake#L7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miqlas right, wasn't aware of it. Then it should just work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not using the INSTALL_DIR options fails on x86_gcc2 for secondaryArchSuffix ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Begasus, fine, the packages don't always correctly use the first provided by cmakeDirArgs. Ok to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from removing DevIL from the recipe it builds ok here, miqlas tested the build on x86_64 :)