Add cadaver recipe

[pjht]

This is my submission for the google code-in task

[Begasus]

Please adjust the suggested changes

[Begasus]

There is a trailing white-space, check the line endings for spaces

[pjht]

I've implemented the changes.

[scottmc]

Seems you still have a trailing white space issue that travis-ci is complaining about.

[pjht]

Fixed

[pjht]

All good.

[fbrosson]

minor style issues

[Begasus]

I'll leave the rest of the changes need to be done followed up by @fbrosson , thanks for the contribution @pjht !

[fbrosson]

Thanks @Begasus! You did the most difficult part of the mentoring!
To tell the truth I did not even dare to write a review yesterday 😄

[pjht]

Did the changes

[fbrosson]

Oops, we have a small typo: {lib,devel}:libzlib ➡️ {lib,devel}:libz

[fbrosson]

Oops, I tried cadaver on a site served through https and got this warning: SSL is not enabled.
It seems we need to pass some configure option to enable ssl support, because right now this is what we have:

objdump -x /bin/cadaver |grep NEEDED
  NEEDED      libreadline.so.7
  NEEDED      libncurses.so.6
  NEEDED      libintl.so.8
  NEEDED      libnetwork.so
  NEEDED      libexpat.so.1
  NEEDED      libroot.so

[Begasus]

Think I already mentioned openssl yesterday on IRC :)
EDIT, nvm it's in the requirements, maybe use an EXPORT LIBS = for -lnetwork (or patch configure to check for that)?

[pjht]

libzlib changed to libz

[Begasus]

@fbrosson for me it's been a good task, so for creating the recipe it's ok for me, the part failing with ssl could be dealt with later

[Begasus]

hmm ... did you check if config.log is looking for libcrypto also? ;)

[pjht]

So are you going to mark my task complete?

[Begasus]

I can't see your task in my instances, so I guess @fbrosson needs to approve then :)

[fbrosson]

I'm adding a "help-wanted" label in case someone has an idea on how to fix the ssl issue.
@pulkomandy?

[fbrosson]

I can't see your task in my instances, so I guess @fbrosson needs to approve then :)

Done :)
That said, if I'm not mistaken, one does not need to be mentor on a task to approve it. Any mentor on the Org can approve any task from that same Org.

[kenmays]

@pjht - Add neon to your build requirements. Use --with-neon flag in configure.

[pjht]

@kenmays I added neon and got this error:
checking for neon-config... /bin/neon-config
checking linking against neon... yes
configure: incompatible neon library version 0.30.2: wanted 0.27 28 29
configure: error: could not use external neon library

[pjht]

@kenmays I did

[pjht]

@kenmays I did

[scottmc]

seems cadaver is dead. There i said it. The joke was right in front of us. Anyways, there's likely a patch floating around that adds support for newer neon, check debian or others. Lets mark this task complete and leave this open until the neon/ssl issue is figured out.

[scottmc]

there's likely a patch floating around that adds support for newer neon, check debian or others. Lets mark this task complete and leave this open until the neon/ssl issue is figured out.

likely some hints here on how to fix this:
https://gitweb.gentoo.org/repo/gentoo.git/tree/net-misc/cadaver/cadaver-0.23.3.ebuild
perhaps wrap this recipe up as is, or mark as broken and merge, then add a new issue to resolve the neon/ssl issue, which might take a bit more work.

[kenmays]

@pjht - You'll need to patch the check neon version in your configure.ac file to allow it to use neon 0.30.

[scottmc]

@pjht - You'll need to patch the check neon version in your configure.ac file to allow it to use neon 0.30.

It's likely a rabbit hole... you'll need to patch configure.ac to use neon 0.30, then you'll need to add autoreconf, then you'll find that it needs a newer neon.m4 file added, then ... it'll likely be several more iterations until you arrive at the final solution. I say mark it at broken on all architectures, get it merged, and open a new ticket to fix the neon issue, and it's likely to take a few more steps to resolve.

[fbrosson]

We don't need to mark the recipe as broken because it is working. It's just that it will only be able to access http sites.
That said, using a WebDAV service on http is not a good idea unless one is not afraid of sending passwords through http.

In other words, if we merge this PR then I think it would be OK to keep it enabled.
Hmm, why don't we just mark it as untested?

Anyway, there is no urgency, so we can keep the PR open for now and think about it for the next days.

[scottmc]

It's my understanding that if it is marked as working then it could end up in HaikuDepot? I'd like to prevent it from getting there until the SSL issue is fixed. Would marking it as untested have the same effect?

[fbrosson]

Yep, marking it as untested will make the build bots skip it, so pre-built packages won't be available. I think this can be a nice scenario for now if we don't find a better fix.
This would be nice because any user willing to try this ssl-disabled cadaver can still build it from sources without having to edit the recipe locally.

I have cadaver on Debian 9 (Stretch) and am able to access (read&write) https webdavs.

$ cadaver --version
cadaver 0.23.3
neon 0.30.2: Library build, IPv6, libxml 2.9.4, zlib 1.2.8, GNU TLS 3.5.6.
readline 7.0

$ cadaver https://example.org/dav/
Authentication required for private on server `example.org':
Username: me
Password: 
dav:/dav/> ls
Listing collection `/dav/': succeeded.

(The webdav site I used is not example.org but a private remote webdav I control.)

I haven't investigated yet all possible paths (i.e. autoreconf, looking for a patch from a Linux distro such as Debian, Gentoo or ArchLinux) so we might be able to fix the ssl issue before the merge.
I'd say that if we don't find a fix before next week then maybe we can mark cadaver as untested and still merge.

[Begasus]

It is possible it seems :) (from config.log)

configure:9610: using neon library 0.30.2
configure:9657: SSL is supported by neon

[Begasus]

Ok, got it build with the 0.30.2 version from neon, not sure how to test though :) (with a small patch in configure)
EDIT, build for x86_gcc2 and x86_64
SECOND EDIT :) output from objdumb on x86_64

~> objdump -x /bin/cadaver |grep NEEDED
    NEEDED               libreadline.so.7
    NEEDED               libncurses.so.6
    NEEDED               libintl.so.8
    NEEDED               libneon.so.27
    NEEDED               libnetwork.so
    NEEDED               libz.so.1
    NEEDED               libssl.so.1.0.0
    NEEDED               libcrypto.so.1.0.0
    NEEDED               libxml2.so.2
    NEEDED               libroot.so

[Begasus]

@pjht - Add neon to your build requirements. Use --with-neon flag in configure.

When neon is provided in the REQUIRES and REQUIRES_devel the --with-neon flag isn't required for configure (provided configure is patched)

[Begasus]

This could be used as a pointer on how to patch configure :)
https://github.com/Homebrew/homebrew-core/blob/master/Formula/cadaver.rb