Drawpile Icon #2

[BachToTheFuture]

@fbrosson @humdingerb @Begasus This is the new PR for my icon :)
Should fix #3261 If everything was done correctly.

[pulkomandy]

On Wed, Oct 31, 2018 at 10:06:00AM -0700, fbrosson wrote: @humdingerb, @Begasus, what header would you recommend here? * `resource(1) #'VICN' array {` * `resource #'VICN' array {` * `resource vector_icon array {` * `resource vector_icon {`

They all do the same thing. It seems convenient to have the app icon always stored with the id 1, so I'd keep that. In case a file has multiple icons stored as resources, it makes it easy to find the icon to use for the app.

[BachToTheFuture]

@pulkomandy so do you think I should keep resource(1) #'VICN' array {?

[pulkomandy]

On Wed, Oct 31, 2018 at 07:19:42PM +0000, Bach Nguyen wrote: @pulkomandy so do you think I should keep `resource(1) #'VICN' array {`?

Yes that's fine.

[fbrosson]

We currently have:

• 2 recipes with resource(11) #'VICN' array (games-puzzle/numptyphysics and media-sound/schismtracker)
• 46 recipes with resource vector_icon array {
• 125 recipes with resource vector_icon {

If all these strings are equivalent (except for the index), why not use what is already the biggest trend?

@bach5000, I'd keep the resource vector_icon {.
(There's absolutely no need to put back anything else.)

[BachToTheFuture]

@humdingerb @fbrosson GCI website doesn't work. I'm trying submit the task for proposing Haiku's mascot but I can't.
Where can I submit instead?

[fbrosson]

@bach5000, I just left a message in the task instance, 5894692148346880.

[humdingerb]

I recently uploaded a file with QupZilla, via drag&drop even...

[hako]

Is this PR ready to be merged or are there any outstanding issues?

[scottmc]

@bach5000 can you recheck this one and let us know the status, it'd be nice to get it merged soon.

[BachToTheFuture]

@scottmc I believe it's ready to be merged.