Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cowsay: bump to 3.04 #3382

Merged
merged 1 commit into from Nov 17, 2018
Merged

cowsay: bump to 3.04 #3382

merged 1 commit into from Nov 17, 2018

Conversation

Crestwave
Copy link
Contributor

No description provided.

alaviss
alaviss reviewed Nov 17, 2018
View reviewed changes
Copy link
Contributor

@alaviss alaviss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cowsay should be patched to look for cows in B_FIND_PATH_DATA_DIRECTORY, since with the current setup, it can only seek for cows that came with it. That's not required for this PR however.

games-misc/cowsay/cowsay-3.04.recipe
@@ -5,8 +5,8 @@ HOMEPAGE="https://github.com/tnalpgge/rank-amateur-cowsay"
COPYRIGHT="1999-2000 Tony Monroe"
LICENSE="GNU GPL v3"
REVISION="1"
SOURCE_URI="$HOMEPAGE/archive/$portName-$portVersion.tar.gz"
CHECKSUM_SHA256="9a32cba0b561719e1302398857124fdf4dd21a7623c017eaadbf31277f9274af"
SOURCE_URI="$HOMEPAGE/archive/cowsay-$portVersion.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not strictly required in this case, since the architecture was any.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I just changed it since there's no alternative to the value, and $portName isn't shorter than cowsay.

@fbrosson
Copy link
Member

Thanks @Crestwave for your PR!

@alaviss:

I think cowsay should be patched to look for cows in B_FIND_PATH_DATA_DIRECTORY, since with the current setup, it can only seek for cows that came with it. That's not required for this PR however.

$ grep COWPATH /bin/cowsay 
$cowpath = $ENV{'COWPATH'} || '/packages/cowsay-3.04-1/.self/data/cows';

@alaviss: Anyone willing to have other data files can set COWPATH to e.g. /boot/home/data/cows:/boot/system/data/cows, so I also think we can merge this PR and have a separate PR for the patch you are suggesting, in case someone would like to implement it.

So, shall we merge as is?

@fbrosson fbrosson merged commit a4a941c into haikuports:master Nov 17, 2018
BachToTheFuture pushed a commit to BachToTheFuture/haikuports that referenced this pull request Dec 1, 2018
@Crestwave @BachToTheFuture
cowsay: bump to 3.04 (haikuports#3382)
d619db0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alaviss alaviss alaviss approved these changes

@fbrosson fbrosson fbrosson approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Crestwave @fbrosson @alaviss